Skip to content

Fix typos and improve grammar in threading.Barrier docstrings #12210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 1 commit into from
Mar 9, 2019
Merged

Fix typos and improve grammar in threading.Barrier docstrings #12210

miss-islington merged 1 commit into from
Mar 9, 2019

Conversation

@carlbordum
Copy link
Contributor

@carlbordum carlbordum commented Mar 7, 2019

No description provided.

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Mar 7, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

rougeth
rougeth reviewed Mar 7, 2019
View reviewed changes
rougeth
rougeth approved these changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@rougeth rougeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mariatta Mariatta changed the title no-bpo: fix two typos in threading.Barrier docstrings Fix typos and improve grammar in threading.Barrier docstrings Mar 9, 2019
@miss-islington miss-islington merged commit 62fa51f into python:master Mar 9, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Mar 9, 2019

Thanks @carlbordum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Mar 9, 2019

GH-12254 is a backport of this pull request to the 3.7 branch.

@Mariatta
Copy link
Member

Mariatta commented Mar 9, 2019

Thanks @carlbordum and congrats on your first contribution to CPython 🌮

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 9, 2019
@carlbordum @miss-islington
Fix typos and improve grammar in threading.Barrier docstrings (python…
c1e01ed 
…GH-12210)

(cherry picked from commit 62fa51f)

Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
miss-islington added a commit that referenced this pull request Mar 9, 2019
@miss-islington @carlbordum
Fix typos and improve grammar in threading.Barrier docstrings (GH-12210)
4e2079d 
(cherry picked from commit 62fa51f)

Co-authored-by: Carl Bordum Hansen <carl@bordum.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

+1 more reviewer

@rougeth rougeth rougeth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@carlbordum @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta @rougeth