gh-120930: Remove extra blank occuring in wrapped encoded words in email headers#121747
Merged
encukou merged 2 commits intopython:mainfrom Jul 18, 2024
Merged
gh-120930: Remove extra blank occuring in wrapped encoded words in email headers#121747encukou merged 2 commits intopython:mainfrom
encukou merged 2 commits intopython:mainfrom
Conversation
… folding EmailMessage
|
All commit authors signed the Contributor License Agreement. |
hugovk
approved these changes
Jul 14, 2024
Member
hugovk
left a comment
There was a problem hiding this comment.
Thank you for the fix! Looks good (assuming tests pass).
Let's give @python/email-team a chance to review as well.
bitdancer
reviewed
Jul 15, 2024
Misc/NEWS.d/next/Library/2024-07-14-11-18-28.gh-issue-120930.Kuo4L0.rst
Outdated
Show resolved
Hide resolved
Member
|
LGTM, though I did suggest an alternative phrasing for the news item. |
|
Thanks @matthieucan for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 18, 2024
… in email headers (pythonGH-121747) (cherry picked from commit cecacee) Co-authored-by: Matthieu Caneill <matthieucan@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 18, 2024
… in email headers (pythonGH-121747) (cherry picked from commit cecacee) Co-authored-by: Matthieu Caneill <matthieucan@users.noreply.github.com>
|
GH-121963 is a backport of this pull request to the 3.13 branch. |
|
GH-121964 is a backport of this pull request to the 3.12 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some changes applied in ffe9ba0 to fix whitespace between encoded words when folding an EmailMessage, the following issue was introduced:
This patch fixes the special case.