gh-120291: Fix a bashism in python-config.sh.in#120292
Merged
sobolevn merged 1 commit intopython:mainfrom Jun 11, 2024
Merged
Conversation
picnixz
reviewed
Jun 9, 2024
Member
picnixz
left a comment
There was a problem hiding this comment.
Can you also check that the script is in sync with python-config.in as asked?
Misc/NEWS.d/next/Build/2024-06-09-15-54-22.gh-issue-120291.IpfHzE.rst
Outdated
Show resolved
Hide resolved
Replace the use of bash-specific `[[ ... ]]` with POSIX-compliant `[ ... ]` to make the `python-config` shell script work with non-bash shells again. While at it, use `local` in a safer way, since it is not in POSIX either (though universally supported). Fixes python#120291
sobolevn
approved these changes
Jun 9, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2024
pythongh-120291: Fix bashisms in python-config.sh.in Replace the use of bash-specific `[[ ... ]]` with POSIX-compliant `[ ... ]` to make the `python-config` shell script work with non-bash shells again. While at it, use `local` in a safer way, since it is not in POSIX either (though universally supported). Fixes pythonGH-120291 (cherry picked from commit 7d24471) Co-authored-by: Michał Górny <mgorny@gentoo.org>
|
GH-120341 is a backport of this pull request to the 3.13 branch. |
Member
|
Thank you! Backport will be merged as soon as the CI will pass. I wonder if we can use |
sobolevn
pushed a commit
that referenced
this pull request
Jun 11, 2024
…120341) gh-120291: Fix a bashism in python-config.sh.in (GH-120292) gh-120291: Fix bashisms in python-config.sh.in Replace the use of bash-specific `[[ ... ]]` with POSIX-compliant `[ ... ]` to make the `python-config` shell script work with non-bash shells again. While at it, use `local` in a safer way, since it is not in POSIX either (though universally supported). Fixes GH-120291 (cherry picked from commit 7d24471) Co-authored-by: Michał Górny <mgorny@gentoo.org>
Contributor
Author
|
Thanks! |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
pythongh-120291: Fix bashisms in python-config.sh.in Replace the use of bash-specific `[[ ... ]]` with POSIX-compliant `[ ... ]` to make the `python-config` shell script work with non-bash shells again. While at it, use `local` in a safer way, since it is not in POSIX either (though universally supported). Fixes python#120291
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
pythongh-120291: Fix bashisms in python-config.sh.in Replace the use of bash-specific `[[ ... ]]` with POSIX-compliant `[ ... ]` to make the `python-config` shell script work with non-bash shells again. While at it, use `local` in a safer way, since it is not in POSIX either (though universally supported). Fixes python#120291
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
pythongh-120291: Fix bashisms in python-config.sh.in Replace the use of bash-specific `[[ ... ]]` with POSIX-compliant `[ ... ]` to make the `python-config` shell script work with non-bash shells again. While at it, use `local` in a safer way, since it is not in POSIX either (though universally supported). Fixes python#120291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the use of bash-specific
[[ ... ]]with POSIX-compliant[ ... ]to make thepython-configshell script work with non-bash shells again.Fixes #120291
python-configstarted using bashisms #120291