gh-120170: Exclude __mp_main__ in C version of whichmodule()#120171
Conversation
|
The following commit authors need to sign the Contributor License Agreement: Click the button to sign: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
With respect to the CLA, I am making this contribution on behalf of my organization, D. E. Shaw & Co., L.P. In 2018 we signed a CLA associated with the bugs.python.org username |
Importing multiprocessing adds an alias to __main__ named __mp_main__. In python#23403, the Python version of whichmodule() was fixed to exclude __mp_main__. Apply the same fix to the C version of the function.
|
@li-dan You'll need to sign the CLA individually as well. |
|
Thanks for taking a look at this, @lysnikolaou. Is there any documentation on the CLA policy? My organization is making this contribution and holds rights to the contribution, so it doesn't seem correct that I should be involved in the licensing process as an individual. |
|
All commit authors signed the Contributor License Agreement. |
|
@li-dan With the current CLA setup you'll also need to sign an individual CLA. Please could you do that? See also https://www.python.org/psf/contrib/ which says "The PSF is now asking all past and future contributors to sign a Contributor Agreement." Thank you. |
|
I'm happy to sign the CLA in my personal capacity, but it would not be able to apply to this PR. My organization is licensing this contribution, and as an individual, I do not have rights to grant a license to the contribution. Is that okay? |
|
Yes, this is okay. We are not aware of the geographical jurisdiction of each particular company and employee. We are also not privy to their particular contract and details about the form of their collaboration. Laws differ between all those cases. Therefore, we always require individual CLAs. In the case where a blanket organizational CLA already covers a company, and the copyright of a PR is already legally assigned to the company, this is a no-op legally. Such a contributor isn't granting any additional licenses that weren't already granted. But even in this case, it allows Python to track which employees are contributors. It also covers the case where a contributor deliberately or otherwise uses a private email address when authoring their commits. |
|
Thanks for the background, @ambv. I am consulting with my employer on how we want to proceed. |
|
I have signed the individual CLA. |
|
Thank you! @lysnikolaou Does this need backporting? |
|
I think this qualifies as a bug, so probably should be backported, but I'm not sure. |
…ython#120171) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
…ython#120171) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
…ython#120171) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Importing multiprocessing adds an alias to
__main__named__mp_main__. In #23403, the Python version of whichmodule() was fixed to exclude__mp_main__. Apply the same fix to the C version of the function.