Skip to content

[3.4] bpo-34791: xml package obeys ignore env flags (GH-9544)#11872

Merged
larryhastings merged 2 commits intopython:3.4from
vstinner:xml_ignore_env34
Feb 25, 2019
Merged

[3.4] bpo-34791: xml package obeys ignore env flags (GH-9544)#11872
larryhastings merged 2 commits intopython:3.4from
vstinner:xml_ignore_env34

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 15, 2019 •
edited by bedevere-bot
Loading

The xml.sax and xml.dom.domreg modules now obey
sys.flags.ignore_environment.

Signed-off-by: Christian Heimes christian@python.org

(cherry picked from commit 223e501)

https://bugs.python.org/issue34791

@tiran @vstinner
bpo-34791: xml package obeys ignore env flags (GH-9544)
4ee5c4b 
The xml.sax and xml.dom.domreg modules now obey
sys.flags.ignore_environment.

Signed-off-by: Christian Heimes <christian@python.org>

(cherry picked from commit 223e501)
@bedevere-bot bedevere-bot added the type-security A security issue label Feb 15, 2019
@matrixise
Copy link
Member

matrixise commented Feb 15, 2019

@vstinner LGTM

@larryhastings
Copy link
Contributor

larryhastings commented Feb 25, 2019

Appveyor claims the build failed... but AFAICT everything was fine. There are no reported build errors, and no test failures. Did it simply time out?

@vstinner
Copy link
Member Author

vstinner commented Feb 25, 2019

Appveyor claims the build failed... but AFAICT everything was fine. There are no reported build errors, and no test failures. Did it simply time out?

I clicked on "Re-Build PR" to test again this PR. (@larryhastings you should get the button as well if you log in appveyor.com, it's connected to GitHub and so you get the permission from the Python group.)

The log ends with "[389/391] test_urllib2net" as if the job has been cancelled or stopped. The job says " Failed 5 minutes ago in 13 min 35 sec". Another recent successful job took 17 min.

Stop stressing AppVeyor, you make it grumpy :-(

@larryhastings
Copy link
Contributor

larryhastings commented Feb 25, 2019

I would send Appveyor chocolates and love letters if it would help!

@larryhastings larryhastings merged commit 765d333 into python:3.4 Feb 25, 2019
@bedevere-bot
Copy link

bedevere-bot commented Feb 25, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings
Copy link
Contributor

larryhastings commented Feb 25, 2019

Thanks for the backport! 3.4 salutes you, as it rides off into the sunset.

@vstinner vstinner deleted the xml_ignore_env34 branch February 25, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vstinner @matrixise @larryhastings @bedevere-bot @gpshead @the-knights-who-say-ni @tiran