Skip to content

bpo-35283: Update the docstring of threading.Thread.join method #11596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Jan 18, 2019
Merged

bpo-35283: Update the docstring of threading.Thread.join method #11596

vstinner merged 1 commit into from
Jan 18, 2019

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Jan 17, 2019 •
edited by bedevere-bot
Loading

@corona10 corona10 changed the title bpo-35283: Update the docstring of threading.Thread.isAlive method bpo-35283: Update the docstring of threading.Thread.join method Jan 17, 2019
@corona10
Copy link
Member Author

corona10 commented Jan 17, 2019

@vstinner @asvetlov
I found that the docstring of threading.Thread.join should be updated to use is_alive.
And also it needs to apply 3.x versions. What do you think?

vstinner
vstinner reviewed Jan 18, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the NEWS entry. It's not worth it. I will add "skip news" label instead.

@corona10
Copy link
Member Author

corona10 commented Jan 18, 2019

@vstinner
I remove the NEWS entry as you comment.
Thanks always

@vstinner vstinner merged commit 36d9e9a into python:master Jan 18, 2019
corona10 added a commit to corona10/cpython that referenced this pull request Jan 18, 2019
@corona10
bpo-35283: Update the docstring of threading.Thread.join method (pyth…
a723f74 
…onGH-11596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10 @vstinner @eamanu @the-knights-who-say-ni @bedevere-bot