gh-114803: Mention that @dataclass should not be applied on enums#114891
Merged
ethanfurman merged 5 commits intopython:mainfrom Feb 3, 2024
Merged
gh-114803: Mention that @dataclass should not be applied on enums#114891ethanfurman merged 5 commits intopython:mainfrom
@dataclass should not be applied on enums#114891ethanfurman merged 5 commits intopython:mainfrom
Conversation
Eclips4
reviewed
Feb 2, 2024
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
ethanfurman
requested changes
Feb 2, 2024
Member
ethanfurman
left a comment
There was a problem hiding this comment.
A couple minor changes. Thanks for pushing this forward.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
…to issue-114803
ethanfurman
approved these changes
Feb 3, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…nums (pythonGH-114891) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…nums (pythonGH-114891) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure about the code sample though: do we need this incorrect example? Or should I remove it?
📚 Documentation preview 📚: https://cpython-previews--114891.org.readthedocs.build/