Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jan 8, 2019

Fix a memory leak in asyncio in the ProactorEventLoop when ReadFile()
or WSASend() overlapped operation fail immediately: release the
internal buffer.

https://bugs.python.org/issue32710

Fix a memory leak in asyncio in the ProactorEventLoop when ReadFile()
or WSASend() overlapped operation fail immediately: release the
internal buffer.
@vstinner
Copy link
Member Author

vstinner commented Jan 8, 2019

cc @asvetlov @1st1: yet another major bug in proactor :-(

@vstinner vstinner merged commit a234e14 into python:master Jan 8, 2019
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@vstinner vstinner deleted the overlapped_release_buffer branch January 8, 2019 13:23
@bedevere-bot
Copy link

GH-11471 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2019
Fix a memory leak in asyncio in the ProactorEventLoop when ReadFile()
or WSASend() overlapped operation fail immediately: release the
internal buffer.
(cherry picked from commit a234e14)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington added a commit that referenced this pull request Jan 8, 2019
Fix a memory leak in asyncio in the ProactorEventLoop when ReadFile()
or WSASend() overlapped operation fail immediately: release the
internal buffer.
(cherry picked from commit a234e14)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@asvetlov
Copy link
Contributor

asvetlov commented Jan 8, 2019

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants