bpo-32492: Tweak _collections._tuplegetter.#11367
Merged
serhiy-storchaka merged 8 commits intopython:masterfrom Dec 31, 2018
Merged
bpo-32492: Tweak _collections._tuplegetter.#11367serhiy-storchaka merged 8 commits intopython:masterfrom
serhiy-storchaka merged 8 commits intopython:masterfrom
Conversation
* Remove the docstrings cache. * Improve tests. * Unify names of tp_descr_get and tp_descr_set functions.
Contributor
|
Consider adding another test for |
rhettinger
approved these changes
Dec 30, 2018
Contributor
|
If caching is taken out, then docstring interning should be added back. |
Contributor
|
Also, the test for the exact help() string seems fragile (it depends on the exact spacing and formatting of the help() output). Instead, just check for the presence of the docstring or check that it is data descriptor and leave it at that. |
csabella
pushed a commit
to csabella/cpython
that referenced
this pull request
Dec 31, 2018
* Replace the docstrings cache with sys.intern(). * Improve tests. * Unify names of tp_descr_get and tp_descr_set functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32492