Skip to content

bpo-35454: Fix miscellaneous minor issues in error handling. #11077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Dec 11, 2018
Merged

bpo-35454: Fix miscellaneous minor issues in error handling. #11077

serhiy-storchaka merged 2 commits into from
Dec 11, 2018

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 10, 2018 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 skip news labels Dec 10, 2018
@serhiy-storchaka serhiy-storchaka requested a review from a team December 10, 2018 12:32
ZackerySpytz
ZackerySpytz reviewed Dec 10, 2018
View reviewed changes
@serhiy-storchaka serhiy-storchaka merged commit 8905fcc into python:master Dec 11, 2018
@bedevere-bot
Copy link

bedevere-bot commented Dec 11, 2018

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Dec 11, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the misc-error-handling branch December 11, 2018 06:38
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2018
@serhiy-storchaka @miss-islington
bpo-35454: Fix miscellaneous minor issues in error handling. (pythonG…
553c320 
…H-11077)

* bpo-35454: Fix miscellaneous minor issues in error handling.

* Fix a null pointer dereference.
(cherry picked from commit 8905fcc)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 11, 2018

GH-11105 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Dec 11, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8905fcc85a6fc3ac394bc89b0bbf40897e9497a6 3.6

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 11, 2018
@serhiy-storchaka
[3.6] bpo-35454: Fix miscellaneous minor issues in error handling. (p…
4b28a69 
…ythonGH-11077)

* bpo-35454: Fix miscellaneous minor issues in error handling.

* Fix a null pointer dereference..
(cherry picked from commit 8905fcc)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 11, 2018

GH-11106 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Dec 11, 2018
@miss-islington @serhiy-storchaka
bpo-35454: Fix miscellaneous minor issues in error handling. (GH-11077)
62674f3 
* bpo-35454: Fix miscellaneous minor issues in error handling.

* Fix a null pointer dereference.
(cherry picked from commit 8905fcc)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Dec 11, 2018
@serhiy-storchaka
[3.6] bpo-35454: Fix miscellaneous minor issues in error handling. (G…
8855d93 
…H-11077) (GH-11106)

(cherry picked from commit 8905fcc)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @bedevere-bot @miss-islington @ZackerySpytz @the-knights-who-say-ni