Skip to content

gh-110631: Fix reST indentation in Doc/library#110685

Merged
ezio-melotti merged 1 commit intopython:mainfrom
ezio-melotti:fix-ind-library
Oct 11, 2023
Merged

gh-110631: Fix reST indentation in Doc/library#110685
ezio-melotti merged 1 commit intopython:mainfrom
ezio-melotti:fix-ind-library

Conversation

@ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Oct 11, 2023 •
edited
Loading

This PR fixes indentation errors that resulted in spurious blockquotes and definition lists in the Doc/library dir.

📚 Documentation preview 📚: https://cpython-previews--110685.org.readthedocs.build/

@ezio-melotti ezio-melotti added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 11, 2023
@ezio-melotti ezio-melotti self-assigned this Oct 11, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 11, 2023
Closed
ezio-melotti
ezio-melotti commented Oct 11, 2023
View reviewed changes
Doc/library/tkinter.ttk.rst
Comment on lines 1001 to 1002
the widget is resized.
* width: width
width: width
The width of the column in pixels.
Copy link
Member Author

@ezio-melotti ezio-melotti Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the next few chunks created a weird definition list with bullets. I removed the bullets to create a regular definition list. The markup of the dts could be improved by adding some ``...`` too, to make them stand out more.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Oct 11, 2023

Sphinx indents should be three, not two spaces, no?

@ezio-melotti
Copy link
Member Author

ezio-melotti commented Oct 11, 2023

Sphinx indents should be three, not two spaces, no?

I just time-machined an answer for you here: #110635 (comment)

@erlend-aasland erlend-aasland changed the title gh-110631: fix wrong indentation in the Doc/library dir. gh-110631: Fix reST indentation in the Doc/library dir Oct 11, 2023
erlend-aasland
erlend-aasland reviewed Oct 11, 2023
View reviewed changes
@ezio-melotti ezio-melotti changed the title gh-110631: Fix reST indentation in the Doc/library dir gh-110631: Fix reST indentation in Doc/library Oct 11, 2023
@ezio-melotti ezio-melotti merged commit bb7923f into python:main Oct 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2023

Thanks @ezio-melotti for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2023

Sorry, @ezio-melotti, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bb7923f556537a463c403dc1097726d8a8e1a6f2 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2023
@ezio-melotti @miss-islington
pythongh-110631: Fix reST indentation in Doc/library (pythonGH-110685)
f7b74df 
Fix wrong indentation in the Doc/library dir.
(cherry picked from commit bb7923f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2023

GH-110736 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 11, 2023
ezio-melotti added a commit to ezio-melotti/cpython that referenced this pull request Oct 11, 2023
@ezio-melotti
[3.11] pythongh-110631: Fix reST indentation in Doc/library (python…
809a677 
…GH-110685)

Fix wrong indentation in the Doc/library dir..
(cherry picked from commit bb7923f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2023

GH-110737 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 11, 2023
ezio-melotti added a commit that referenced this pull request Oct 11, 2023
@miss-islington @ezio-melotti
[3.12] gh-110631: Fix reST indentation in Doc/library (GH-110685) (#…
cae968b 
…110736)

gh-110631: Fix reST indentation in `Doc/library` (GH-110685)

Fix wrong indentation in the Doc/library dir.
(cherry picked from commit bb7923f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti added a commit that referenced this pull request Oct 11, 2023
@ezio-melotti
[3.11] gh-110631: Fix reST indentation in Doc/library (GH-110685) (#…
07471cd 
…110737)

* [3.11] gh-110631: Fix reST indentation in `Doc/library` (GH-110685)

Fix wrong indentation in the Doc/library dir..
(cherry picked from commit bb7923f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

* Fix merge glitch.
@ezio-melotti ezio-melotti deleted the fix-ind-library branch October 11, 2023 21:11
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ezio-melotti @Glyphack
pythongh-110631: Fix reST indentation in Doc/library (python#110685)
03e0aa6 
Fix wrong indentation in the Doc/library dir.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@hugovk hugovk hugovk approved these changes

@pradyunsg pradyunsg Awaiting requested review from pradyunsg

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees

@ezio-melotti ezio-melotti

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezio-melotti @erlend-aasland @miss-islington @hugovk