Skip to content

bpo-35363: test_eintr runs eintr_tester.py in verbose mode #10965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Dec 5, 2018
Merged

bpo-35363: test_eintr runs eintr_tester.py in verbose mode #10965

vstinner merged 1 commit into from
Dec 5, 2018

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 5, 2018 •
edited by bedevere-bot
Loading

Moreover, "python3 -m test test_eintr -v" now avoids redirecting
stdout/stderr to a pipe, the child process inherits stdout/stderr
from the parent.

https://bugs.python.org/issue35363

@vstinner
bpo-35363: test_eintr runs eintr_tester.py in verbose mode
be32656 
Moreover, "python3 -m test test_eintr -v" now avoids redirecting
stdout/stderr to a pipe, the child process inherits stdout/stderr
from the parent.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Dec 5, 2018
@vstinner
Copy link
Member Author

vstinner commented Dec 5, 2018

My goal is to debug such issue on buildbot:

https://buildbot.python.org/all/#/builders/170/builds/168

0:11:56 load avg: 4.83 [256/416/1] test_eintr failed -- running: test_concurrent_futures (2 min 22 sec), test_compileall (30 sec 813 ms)
test_all (test.test_eintr.EINTRTests) ... FAIL

======================================================================
FAIL: test_all (test.test_eintr.EINTRTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.7.koobs-freebsd10.nondebug/build/Lib/test/test_eintr.py", line 18, in test_all
    script_helper.assert_python_ok("-u", tester)
  File "/usr/home/buildbot/python/3.7.koobs-freebsd10.nondebug/build/Lib/test/support/script_helper.py", line 157, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/usr/home/buildbot/python/3.7.koobs-freebsd10.nondebug/build/Lib/test/support/script_helper.py", line 143, in _assert_python
    res.fail(cmd_line)
  File "/usr/home/buildbot/python/3.7.koobs-freebsd10.nondebug/build/Lib/test/support/script_helper.py", line 84, in fail
    err))
AssertionError: Process return code is -14
command line: ['/usr/home/buildbot/python/3.7.koobs-freebsd10.nondebug/build/python', '-X', 'faulthandler', '-I', '-u', '/usr/home/buildbot/python/3.7.koobs-freebsd10.nondebug/build/Lib/test/eintrdata/eintr_tester.py']

stdout:
---

---

stderr:
---
......
---

----------------------------------------------------------------------

Ran 1 test in 6.558s

FAILED (failures=1)
test test_eintr failed

cc @pablogsal

@vstinner vstinner merged commit aa8ae90 into python:master Dec 5, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2018

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@vstinner vstinner deleted the test_eintr_verbose branch December 5, 2018 23:18
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2018

GH-10966 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2018
@vstinner @miss-islington
bpo-35363: test_eintr runs eintr_tester.py in verbose mode (pythonGH-…
53e7b0d 
…10965)

Moreover, "python3 -m test test_eintr -v" now avoids redirecting
stdout/stderr to a pipe, the child process inherits stdout/stderr
from the parent.
(cherry picked from commit aa8ae90)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2018

GH-10967 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2018
@vstinner @miss-islington
bpo-35363: test_eintr runs eintr_tester.py in verbose mode (pythonGH-…
ea1307e 
…10965)

Moreover, "python3 -m test test_eintr -v" now avoids redirecting
stdout/stderr to a pipe, the child process inherits stdout/stderr
from the parent.
(cherry picked from commit aa8ae90)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington added a commit that referenced this pull request Dec 5, 2018
@miss-islington @vstinner
bpo-35363: test_eintr runs eintr_tester.py in verbose mode (GH-10965)
0fc3b2f 
Moreover, "python3 -m test test_eintr -v" now avoids redirecting
stdout/stderr to a pipe, the child process inherits stdout/stderr
from the parent.
(cherry picked from commit aa8ae90)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington added a commit that referenced this pull request Dec 5, 2018
@miss-islington @vstinner
bpo-35363: test_eintr runs eintr_tester.py in verbose mode (GH-10965)
4699f2a 
Moreover, "python3 -m test test_eintr -v" now avoids redirecting
stdout/stderr to a pipe, the child process inherits stdout/stderr
from the parent.
(cherry picked from commit aa8ae90)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni