Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Nov 28, 2018

Functional tests of test_thread_time() and test_process_time() are
not reliable on Windows. Remove these tests. Only keep the minimum
tests.

https://bugs.python.org/issue33723

@vstinner
Copy link
Member Author

@pitrou approved my previous attempt: PR #10723.

The "busy loops" of test_process_time() and test_thread_time() are
not reliable and fail randomly on Windows: remove them.
@vstinner vstinner merged commit 48498dd into python:master Nov 28, 2018
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@vstinner vstinner deleted the thread_time branch November 28, 2018 17:30
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2018
The "busy loops" of test_process_time() and test_thread_time() are
not reliable and fail randomly on Windows: remove them.
(cherry picked from commit 48498dd)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot
Copy link

GH-10776 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Nov 28, 2018
The "busy loops" of test_process_time() and test_thread_time() are
not reliable and fail randomly on Windows: remove them.
(cherry picked from commit 48498dd)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants