gh-105509: Simplify the implementation of typing.Annotated#105510
Merged
hauntsaninja merged 4 commits intopython:mainfrom Sep 1, 2023
Merged
gh-105509: Simplify the implementation of typing.Annotated#105510hauntsaninja merged 4 commits intopython:mainfrom
typing.Annotated#105510hauntsaninja merged 4 commits intopython:mainfrom
Conversation
typing.Annotatedtyping.Annotated
Misc/NEWS.d/next/Library/2023-06-08-15-56-45.gh-issue-105509.YIG57j.rst
Outdated
Show resolved
Hide resolved
…IG57j.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
sobolevn
reviewed
Jun 8, 2023
Member
sobolevn
left a comment
There was a problem hiding this comment.
Quick note: right now it is possible to use Annotated in isinstance(1, typing.Annotated). However, it does not make much sense anyway:
>>> isinstance(typing.Annotated[int, 1], typing.Annotated)
False
With this patch applied it will raise a TypeError.
I don't think that it is a big deal.
Member
Author
|
Yeah. You can think up ways that this could break people's code, if they're doing strange things with |
hauntsaninja
approved these changes
Sep 1, 2023
Contributor
hauntsaninja
left a comment
There was a problem hiding this comment.
Looks good to me! Couldn't find any isinstance(..., Annotated) in a quick search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105509
typing.Annotated#105509