Skip to content

gh-89058: remove skip from test_no_hang_on_context_chain_cycle2#102903

Merged
iritkatriel merged 1 commit intopython:mainfrom
iritkatriel:unskip-test
Apr 5, 2023
Merged

gh-89058: remove skip from test_no_hang_on_context_chain_cycle2#102903
iritkatriel merged 1 commit intopython:mainfrom
iritkatriel:unskip-test

Conversation

@iritkatriel
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel commented Mar 22, 2023 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel added the tests Tests in the Lib/test dir label Mar 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 22, 2023
Closed
@iritkatriel iritkatriel added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting core review labels Mar 22, 2023
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 22, 2023

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 7a3308f 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 22, 2023
@iritkatriel iritkatriel added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Mar 22, 2023
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 23, 2023

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 7a3308f 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 23, 2023
vstinner
vstinner approved these changes Apr 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Refleaks buildbots are happy. If there is a real leak, it should be fixed ;-) So far, I failed to reproduce it.

@iritkatriel iritkatriel merged commit 5e7c468 into python:main Apr 5, 2023
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 5, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO + PGO 3.x has failed when building commit 5e7c468.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/442/builds/3920) and take a look at the build logs.
  4. Check if the failure is related to this commit (5e7c468) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/442/builds/3920

Failed tests:

  • test_asyncio

Failed subtests:

  • test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessFastWatcherTests.test_subprocess_consistent_callbacks
  • test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks
  • test_fork_signal_handling - test.test_asyncio.test_unix_events.TestFork.test_fork_signal_handling

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

414 tests OK.

10 slowest tests:

  • test_tools: 14 min 34 sec
  • test_concurrent_futures: 2 min 18 sec
  • test_asyncio: 2 min 17 sec
  • test_multiprocessing_spawn: 1 min 49 sec
  • test_multiprocessing_forkserver: 1 min 38 sec
  • test_signal: 1 min 17 sec
  • test_multiprocessing_fork: 1 min 5 sec
  • test_socket: 35.3 sec
  • test_io: 34.8 sec
  • test_imaplib: 34.5 sec

1 test failed:
test_asyncio

18 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_launcher
test_msilib test_nis test_peg_generator test_perf_profiler
test_startfile test_tix test_tkinter test_ttk test_winconsoleio
test_winreg test_winsound test_wmi test_zipfile64

1 re-run test:
test_asyncio

Total duration: 14 min 43 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/test_asyncio/test_subprocess.py", line 770, in test_subprocess_consistent_callbacks
    self.loop.run_until_complete(main())
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/base_events.py", line 664, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/test_asyncio/test_subprocess.py", line 762, in main
    self.assertEqual(events, [
AssertionError: Lists differ: ['process_exited', ('pipe_data_received', 1, b'stdout')] != [('pipe_data_received', 1, b'stdout'), ('p[95 chars]ted']


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/test_asyncio/test_subprocess.py", line 770, in test_subprocess_consistent_callbacks
    self.loop.run_until_complete(main())
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/base_events.py", line 664, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/test_asyncio/test_subprocess.py", line 762, in main
    self.assertEqual(events, [
AssertionError: Lists differ: [('pi[29 chars]t'), 'process_exited'] != [('pi[29 chars]t'), ('pipe_data_received', 2, b'stderr'), 'pi[57 chars]ted']


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/unittest/async_case.py", line 90, in _callTestMethod
    if self._callMaybeAsync(method) is not None:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/unittest/async_case.py", line 117, in _callMaybeAsync
    return self._asyncioTestContext.run(func, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/support/hashlib_helper.py", line 49, in wrapper
    return func_or_class(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/test_asyncio/test_unix_events.py", line 1938, in test_fork_signal_handling
    self.assertTrue(child_handled.is_set())
AssertionError: False is not true

gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this pull request Apr 8, 2023
@iritkatriel @gaogaotiantian
pythongh-89058: remove skip from test_no_hang_on_context_chain_cycle2 (…
71ffe62 
…python#102903)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@iritkatriel @warsaw
pythongh-89058: remove skip from test_no_hang_on_context_chain_cycle2 (…
bd361e8 
…python#102903)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel @bedevere-bot @vstinner