Skip to content

gh-81652 add MAP_ALIGNED_SUPER FreeBSD and MAP_CONCEAL OpenBSD constants#102191

Merged
corona10 merged 3 commits intopython:mainfrom
yeojin-dev:gh-81652
Feb 24, 2023
Merged

gh-81652 add MAP_ALIGNED_SUPER FreeBSD and MAP_CONCEAL OpenBSD constants#102191
corona10 merged 3 commits intopython:mainfrom
yeojin-dev:gh-81652

Conversation

@yeojin-dev
Copy link
Copy Markdown
Contributor

@yeojin-dev yeojin-dev commented Feb 23, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Feb 23, 2023
Closed
@corona10 corona10 self-assigned this Feb 24, 2023
@corona10 corona10 self-requested a review February 24, 2023 00:20
corona10
corona10 requested changes Feb 24, 2023
View reviewed changes
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 24, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ghost
Copy link
Copy Markdown

ghost commented Feb 24, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@yeojin-dev
Copy link
Copy Markdown
Contributor Author

yeojin-dev commented Feb 24, 2023

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 24, 2023

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

corona10
corona10 approved these changes Feb 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit 347f740 into python:main Feb 24, 2023
@yeojin-dev yeojin-dev deleted the gh-81652 branch February 27, 2023 02:04
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@yeojin-k9 @JelleZijlstra
pythongh-81652: Add MAP_ALIGNED_SUPER FreeBSD and MAP_CONCEAL OpenBSD…
6771dbc 
… constants (pythongh-102191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Assignees

@corona10 corona10

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yeojin-dev @bedevere-bot @corona10 @yeojin-k9