Skip to content

gh-100340: Allows -Wno-int-conversion for wasm#100341

Merged
kushaldas merged 1 commit intopython:mainfrom
kushaldas:wasi17_fix
Jan 18, 2023
Merged

gh-100340: Allows -Wno-int-conversion for wasm#100341
kushaldas merged 1 commit intopython:mainfrom
kushaldas:wasi17_fix

Conversation

@kushaldas
Copy link
Copy Markdown
Member

@kushaldas kushaldas commented Dec 19, 2022 •
edited by bedevere-bot
Loading

Adds new configuration directive to disable int-conversion and then using it for the wasm32-wasi build only. This allows us to build on the version 17 of the wasm-sdk.

How to test manually?

Install the version 17 of the SDK and then run the following command:

./Tools/wasm/wasm_build.py wasi

@bedevere-bot bedevere-bot mentioned this pull request Dec 19, 2022
Closed
@brettcannon
Copy link
Copy Markdown
Member

brettcannon commented Dec 19, 2022

I looked at the output for https://buildbot.python.org/all/#/builders/1046 , but I couldn't find any way to tell what version of the WASI SDK was used to build Python. I know that @tiran set up the buildbots using https://github.com/tiran/ansible-wasm-buildbot .

@kushaldas
Copy link
Copy Markdown
Member Author

kushaldas commented Dec 19, 2022

I looked at the output for https://buildbot.python.org/all/#/builders/1046 , but I couldn't find any way to tell what version of the WASI SDK was used to build Python. I know that @tiran set up the buildbots using https://github.com/tiran/ansible-wasm-buildbot .

@brettcannon The buildbot is using version 16 according to https://github.com/tiran/ansible-wasm-buildbot/blob/main/roles/wasi-sdk/defaults/main.yml#L3

brettcannon
brettcannon reviewed Dec 19, 2022
View reviewed changes
@kushaldas kushaldas force-pushed the wasi17_fix branch 2 times, most recently from 64a65f3 to 8fe9902 Compare December 20, 2022 08:34
@erlend-aasland erlend-aasland self-requested a review December 20, 2022 19:07
erlend-aasland
erlend-aasland approved these changes Jan 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kushaldas
Copy link
Copy Markdown
Member Author

kushaldas commented Jan 18, 2023

This worked on wasi-sdk-19 too.

@kushaldas kushaldas merged commit 75c8133 into python:main Jan 18, 2023
@brettcannon
Copy link
Copy Markdown
Member

brettcannon commented Mar 24, 2023

@kushaldas any reason this wasn't backported?

@merwok
Copy link
Copy Markdown
Member

merwok commented Jun 24, 2023

Came here from your recent blog post — as a small build change that can be considered a bug fix, and would give the benefit of keeping various python versions compatible with the latest wasi runtime, this seems fine to backport!

@merwok merwok added the needs backport to 3.11 only security fixes label Jun 24, 2023
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 24, 2023

Thanks @kushaldas for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2023
@kushaldas @miss-islington
pythongh-100340: Allows -Wno-int-conversion for wasm (pythonGH-100341)
1cd76ef 
Fixes pythonGH-100340 allows -Wno-int-conversion for wasm
(cherry picked from commit 75c8133)

Co-authored-by: Kushal Das <mail@kushaldas.in>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 24, 2023

GH-106066 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 24, 2023
erlend-aasland pushed a commit that referenced this pull request Jun 28, 2023
@miss-islington @kushaldas
[3.11] gh-100340: Allows -Wno-int-conversion for wasm (GH-100341) (#1…
966e0f6 
…06066)

(cherry picked from commit 75c8133)

Co-authored-by: Kushal Das <mail@kushaldas.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

OS-wasi skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kushaldas @brettcannon @merwok @miss-islington @bedevere-bot @erlend-aasland