Skip to content

gh-100077: make test_code.test_invalid_bytecode more robust and maintainable#100078

Merged
iritkatriel merged 1 commit intopython:mainfrom
iritkatriel:test_invalid_bytecode
Dec 7, 2022
Merged

gh-100077: make test_code.test_invalid_bytecode more robust and maintainable#100078
iritkatriel merged 1 commit intopython:mainfrom
iritkatriel:test_invalid_bytecode

Conversation

@iritkatriel
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel commented Dec 7, 2022

  • construct the invalid bytecode via mutation of a valid function, rather than from scratch.
  • assert that 238 is indeed an invalid opcode

Fixes #100077.

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 7, 2022

Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 07310c6
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6390ab97e149310008e16719

Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Discussed offline.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_code.test_invalid_bytecode is a bit cryptic and flaky

3 participants