Skip to content

zipfile.ZipFile overwrites files outside destination path #51221

@schmir

Description

@schmir
mannequin
BPO 6972
Nosy @loewis, @birkenfeld, @gpshead, @amauryfa, @larryhastings, @benjaminp, @ned-deily, @bitdancer, @serhiy-storchaka
Files
  • extract-doc.diff: Update to extract() method documentation
  • zipfile-6972-test.diff: test for directory escape
  • zipfile-6972-patch-2.diff: patch to zipfile module for directory escape, with fix for case sensitive file systems
  • zipfile_fix_arcname_3.patch: Strip leading absolute name part and ".." components
  • zipfile_fix_arcname_4-2.7.patch
  • zipfile_fix_arcname_4-3.x.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2013-02-08.06:19:09.044>
    created_at = <Date 2009-09-22.22:10:50.564>
    labels = ['type-security', 'library', 'release-blocker']
    title = 'zipfile.ZipFile overwrites files outside destination path'
    updated_at = <Date 2013-02-08.20:04:05.696>
    user = 'https://bugs.python.org/schmir'

    bugs.python.org fields:

    activity = <Date 2013-02-08.20:04:05.696>
    actor = 'Arfrever'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2013-02-08.06:19:09.044>
    closer = 'gregory.p.smith'
    components = ['Library (Lib)']
    creation = <Date 2009-09-22.22:10:50.564>
    creator = 'schmir'
    dependencies = []
    files = ['15004', '15005', '15009', '27686', '28932', '28933']
    hgrepos = []
    issue_num = 6972
    keywords = ['patch', 'needs review']
    message_count = 50.0
    messages = ['93021', '93251', '93268', '93269', '93278', '93305', '93330', '93331', '93332', '93333', '93334', '93336', '93349', '93372', '93374', '93375', '93376', '93379', '93380', '93381', '93382', '93396', '93420', '93426', '157763', '157778', '157789', '173526', '173567', '173630', '180681', '181055', '181072', '181102', '181106', '181134', '181158', '181159', '181161', '181162', '181163', '181166', '181171', '181178', '181183', '181188', '181244', '181646', '181647', '181659']
    nosy_count = 14.0
    nosy_names = ['loewis', 'georg.brandl', 'gregory.p.smith', 'amaury.forgeotdarc', 'larry', 'schmir', 'benjamin.peterson', 'ned.deily', 'Arfrever', 'r.david.murray', 'twb', 'catalin.iacob', 'python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'release blocker'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'security'
    url = 'https://bugs.python.org/issue6972'
    versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

    Metadata

    Metadata

    Labels

    release-blockerstdlibStandard Library Python modules in the Lib/ directorytype-securityA security issue

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions