Skip to content

Merge code from releases via tarballs#8

Merged
RonnyPfannschmidt merged 3 commits into
pytest-dev:masterfrom
blueyed:tarballs
Apr 4, 2019
Merged

Merge code from releases via tarballs#8
RonnyPfannschmidt merged 3 commits into
pytest-dev:masterfrom
blueyed:tarballs

Conversation

@blueyed

@blueyed blueyed commented Apr 3, 2019

Copy link
Copy Markdown
Contributor

blueyed added a commit to blueyed/pytest that referenced this pull request Apr 3, 2019
@nicoddemus

Copy link
Copy Markdown
Member

Awesome, thanks a lot! 👍

blueyed added a commit to blueyed/pytest that referenced this pull request Apr 3, 2019
@blueyed

blueyed commented Apr 3, 2019

Copy link
Copy Markdown
Contributor Author

@nicoddemus
You're welcome - that was very nasty (even until realizing that releases and master are way off/different).

Cannot merge myself, but probably @RonnyPfannschmidt should take a quick look at least.

@blueyed

blueyed commented Apr 3, 2019

Copy link
Copy Markdown
Contributor Author

Also here again a clear disadvantage of not having coverage reports - I've only checked that tests are passing.

And another sidenote: the formatting changes were really demotivating here also (unnecessary merge conflicts).

@RonnyPfannschmidt

Copy link
Copy Markdown
Member

thanks for wading trough this minefield,

i believe the merge pain could have been avoided in part by using black and/or a more compatible merge

@RonnyPfannschmidt RonnyPfannschmidt merged commit 27e3652 into pytest-dev:master Apr 4, 2019
@blueyed blueyed deleted the tarballs branch April 4, 2019 11:28
@blueyed

blueyed commented Apr 4, 2019

Copy link
Copy Markdown
Contributor Author

i believe the merge pain could have been avoided in part by using black and/or a more compatible merge

It wasn't too bad in my second attempt, and mainly due to renaming variables also.

Thanks for merging!

clrpackages pushed a commit to clearlinux-pkgs/pytest that referenced this pull request Apr 16, 2019
Anthony Sottile (3):
      blacken-docs more code samples in docs
      pre-commit autoupdate
      Produce a warning when unknown arguments are passed to pytest.param()

Bruno Oliveira (1):
      Preparing release version 4.4.1

Daniel Hahler (12):
      pytester: use monkeypatch with Testdir
      doc: make regen: replace trailing spaces already
      doc/en/Makefile: allow passing in REGENDOC_FILES
      tox.ini: regen: clear pytest cache for stable outcome
      doc/en/Makefile: stabilize output between regendoc versions
      Update via pytest-dev/regendoc#8
      pdb: try to import --pdbcls in pytest_configure only
      Fix test_conftest when run via pytest-randomly
      tests: harden test_immediate_initialiation_and_incremental_are_the_same
      Add _sys_snapshot fixture and use it with more tests
      docs: tbreportdemo: remove obsolete comment
      monkeypatch.syspath_prepend: invalidate import cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants