Fix Missing Fixture Teardown operations#260
Merged
icemac merged 1 commit intopytest-dev:masterfrom Feb 29, 2024
Merged
Conversation
Contributor
|
Thank you for your PR. Due to other PRs the files you changed have been moved around on the master branch. Could you please rebase your changes onto the current master branch? |
When using the only_rerun and rerun_except queries (or both), the plug-in was removing the teardown operations from the call-stack before checking to see if the test should be re-run. This resulted in the stack having all fixture operations removed that did not correspond to a function fixture. This commit adds a private variable to each test item that keeps track of whether a test encountered a terminal error. The plugin now checks if a test has encountered a terminal error before attempting to clear the stack. This commit fixes: - pytest-dev#241 - pytest-dev#234
e6c43c5 to
6727700
Compare
Contributor
Author
|
@icemac Rebased! Let me know if you require any other updates. |
icemac
approved these changes
Feb 28, 2024
Contributor
icemac
left a comment
There was a problem hiding this comment.
LGTM from reading through the code.
The-Compiler
added a commit
that referenced
this pull request
Mar 29, 2025
hugovk
pushed a commit
that referenced
this pull request
Aug 27, 2025
icemac
added a commit
that referenced
this pull request
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the only_rerun and rerun_except queries (or both), the plug-in was removing the teardown operations from the call-stack before checking to see if the test should be re-run. This resulted in the stack having all fixture operations removed that did not correspond to a function fixture.
This commit adds a private variable to each test item that keeps track of whether a test encountered a terminal error. The plugin now checks if a test has encountered a terminal error before attempting to clear the stack.