Shuffle before other test collection hooks#377
Merged
adamchainz merged 1 commit intomainfrom Aug 13, 2021
Merged
Conversation
graingert
approved these changes
Aug 13, 2021
Member
graingert
left a comment
There was a problem hiding this comment.
frickin' amazing
now somehow need to make this work for stepwise/xdist/randomly all at once!
Member
Author
|
xdist means nondeterministic runtime ordering though? :/ |
Member
|
yeah but it should be mostly fine, with hash ordering on collection it should "just work" I think the only change is that the xdist workers need to communicate the first test that failed rather than the last test that failed. (hey what's that, a bug due to lack of structured concurrency?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #376.