Use exact comparison for bool in approx()#9354
Conversation
|
Hi @jvansanten, Was taking a look at the list of PRs and this one seems to have gone unnoticed, sorry about that. Overall all changes look good to me, I left a comment about the changelog only. Would you like to finish it up? If you don't have the time please let us know so we can do it. Thanks, and sorry for the delay again! |
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
For approx of bool, doesn't it semantically make sense to check for truthy values when requested explicitly, but also ensure is checks for implicit matches in lists mappings
|
hey, I just got into this problems these days and found this PR. What is it missing to get this over the line please? |
|
Seems this fell through the cracks, thanks for the ping. I will rebase. @RonnyPfannschmidt anything else you would like changed here before we merge it? |
|
Will squash/merge in the next few days. Thanks @jvansanten for the PR and sorry that we missed this one. Also thanks @marcelotrevisani for the ping! |
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
its good as is atm - the more tricky details are for when we implement matchers
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #13013 🤖 @patchback |
Also fix list comparison that was only comparing the first element... Ref pytest-dev/pytest#9354 Ref pytest-dev/pytest#13218
Fixes #9353.