Skip to content

tests: Migrate testing/python to pytester fixture#8111

Merged
bluetech merged 1 commit intopytest-dev:masterfrom
antonblr:testdir-to-pytester-python
Dec 13, 2020
Merged

tests: Migrate testing/python to pytester fixture#8111
bluetech merged 1 commit intopytest-dev:masterfrom
antonblr:testdir-to-pytester-python

Conversation

@antonblr
Copy link
Copy Markdown
Member

@antonblr antonblr commented Dec 10, 2020 •
edited
Loading

Another batch of fixes for #7942 - migrated everything under testing/python/ dir.

*-py37-pluggy builds are timing out due to the new pip resolver (see the logs) - perhaps dependencies versions have to be defined stricter.

@antonblr antonblr force-pushed the testdir-to-pytester-python branch 2 times, most recently from 696c5cf to b0773f2 Compare December 10, 2020 07:32
@antonblr antonblr marked this pull request as ready for review December 10, 2020 07:34
@bluetech bluetech mentioned this pull request Dec 10, 2020
Closed
@bluetech
Copy link
Copy Markdown
Member

bluetech commented Dec 10, 2020

@antonblr I opened issue #8117 to track the pip resolver thing, thanks for figuring it out. You can probably ignore it for now unless you can come up with a fix for it :)

bluetech
bluetech reviewed Dec 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @antonblr! These are some of the largest files, I know it must have taken some effort to convert them.

I left a few comments, but otherwise LGTM.

I'll try to do the pathlib conversion now.

@bluetech
Copy link
Copy Markdown
Member

bluetech commented Dec 11, 2020

I think we ought to just convert this to use Path entirely. (We have a "project" for this: https://github.com/pytest-dev/pytest/projects/4). I'll work on a PR doing this.

That's #8122. Naturally it conflicts with this PR, so it would need to be rebased after #8122 is merged. I can help with that if needed.

@antonblr
Copy link
Copy Markdown
Member Author

antonblr commented Dec 11, 2020

That's #8122. Naturally it conflicts with this PR, so it would need to be rebased after #8122 is merged. I can help with that if needed.

thanks @bluetech - I'll rebase, once it's in.

@bluetech
Copy link
Copy Markdown
Member

bluetech commented Dec 13, 2020

@antonblr With #8122 merged this should be good for a rebase.

@antonblr antonblr force-pushed the testdir-to-pytester-python branch from b0773f2 to 4ed9a38 Compare December 13, 2020 15:46
@antonblr antonblr changed the title Migrate to pytester: testing/python/ tests: Migrate testing/python to pytester fixture Dec 13, 2020
bluetech
bluetech approved these changes Dec 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @antonblr!

@bluetech bluetech merged commit ad65e81 into pytest-dev:master Dec 13, 2020
@antonblr antonblr deleted the testdir-to-pytester-python branch December 13, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluetech bluetech bluetech approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonblr @bluetech