Hello. We think that this PR broke pytest-doctestplus plugin downstream. Example log: https://github.com/astropy/pytest-doctestplus/pull/139/checks?check_run_id=1558353239 . Not sure if the breakage is intentional. Any advice would be greatly appreciated. Thanks!

cc @saimn

Hi @pllim,

This PR refactored some internal code, I see pytest_doctestplus/plugin.py:437 calls _getconftest_pathlist:

/Users/runner/work/pytest-doctestplus/pytest-doctestplus/.tox/py38-test-pytestdev/lib/python3.8/site-packages/pytest_doctestplus/plugin.py:437: in pytest_ignore_collect
    collect_ignore = config._getconftest_pathlist("collect_ignore", path=path.dirpath())

This PR changed that path parameter from py.path.local to Path.

I believe changing that line to:

    collect_ignore = config._getconftest_pathlist("collect_ignore", path=Path(path).parent)

Should fix that issue. 👍

Hmm... now it fails here:

______________________ ERROR collecting tests/conftest.py ______________________
../../.tox/py38-test-pytestdev/lib/python3.8/site-packages/pytest_doctestplus/plugin.py:196: in collect
    module = self.config.pluginmanager._importconftest(
../../.tox/py38-test-pytestdev/lib/python3.8/site-packages/_pytest/config/__init__.py:560: in _importconftest
    key = conftestpath.resolve()
E   AttributeError: 'LocalPath' object has no attribute 'resolve'

scientific-python/pytest-doctestplus#140

UPDATE: Looks like forcing self.fspath to be Path before passing it into _importconftest works but hopefully not too hacky.

UPDATE: Looks like forcing self.fspath to be Path before passing it into _importconftest works but hopefully not too hacky.

No, that's the correct approach.

Some background: we are in the process of changing internal functions to use Path instead of py.path.local, with the long term goal of eventually deprecating/removing the dependency to the py library. While we try to shield those changes from end users, changing the actual internal functions is unavoidable, so this unfortunately will have consequences to plugins which call internal functions (and we understand there are many situations where there are no other options other than call those internal functions).

We are sorry for the disruption that this might cause, but please bear with us. 👍

No worries and thanks for the timely help, @nicoddemus !