Merged
Conversation
nicoddemus
approved these changes
Jul 4, 2020
Member
nicoddemus
left a comment
There was a problem hiding this comment.
Awesome!
I think I can say for everyone how we are grateful to you for spearing head this effort. 👍
Member
|
I was about to say "awesome work, I gave it a try with my codebase (qutebrowser) and didn't run into any issues". Then I discovered that mypy was only checking my Either way: Awesome work! 👍 |
ekeih
added a commit
to ekeih/alerticular
that referenced
this pull request
May 5, 2021
pytest: Update to recent release which includes types thanks to pytest-dev/pytest#7448 telegram_click_aio: Ignore aiogram: Ignore prometheus_async: Ignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3342. All of the relevant TODOs outlined in #3342 (comment) are covered now so I think we're good to go.