Clear node collection cache after collection is done#6491
Clear node collection cache after collection is done#6491nicoddemus merged 1 commit intopytest-dev:featuresfrom
Conversation
blueyed
left a comment
There was a problem hiding this comment.
I think the renaming is not necessary, and if so should go with type hints then at least.
I find it makes the intent of the cache clearer (only meant to use during collection); unless you are against it I would like to keep it. I will add the type hints, thanks. 👍 |
284f5b6 to
7d09db9
Compare
7d09db9 to
f84157e
Compare
|
Done, thanks for the pointers! Had to add a few more type hints and also applied the same logic to the old I want to eventually refactor the entire logic out of the |
bluetech
left a comment
There was a problem hiding this comment.
Looks like a good change to me.
Is this meant to fix a correctness issue or just optimization/reduce memory usage?
Also rename the involved variables to convey its intent better and add type hints
f84157e to
7b1e3d1
Compare
The latter. 😁 |
|
Rebased this on features too, as it should be. |
Pulled out of pytest-dev#6491.
Pulled out of pytest-dev#6491.
Pulled out of pytest-dev#6491.
Also rename the variable to convey its intent better