Release 4.4.0 by nicoddemus · Pull Request #5014 · pytest-dev/pytest

nicoddemus · 2019-03-29T20:50:54Z

No description provided.

…features Merge master into features

…features Merge master into features (including fix from 4816)

Fix pytest-dev#4815

AppVeyor: use xdist with pypy, drop pluggymaster

Fixes pytest-dev#4718

Require funcsigs>=1.0 on Python 2.7

Change -p so it is possible to early load setuptools plugins

Merge master into features

Move import of _format_explanation in _pytest.assertion.rewrite

--pdbcls: improve validation, and allow for "mod:attr.class"

…_ADDOPTS pytester: unset PYTEST_ADDOPTS

It is only called with empty/new dirs since 0385c27.

cacheprovider: _ensure_supporting_files: remove unused branches

…correct order Fix pytest-dev#1895

Fix pytest-dev#4875

…header-4875 Show testpaths option in the header if it has been used for collection

Co-Authored-By: nicoddemus <nicoddemus@gmail.com>

…eanup-1895 getfixturevalue does not correctly declare dependency with the calling fixture

Conflicts: appveyor.yml setup.py

Serialization hooks

stepwise: report status via pytest_report_collectionfinish

pdb: handle capturing with fixtures only

setup.cfg: use existing [tool:pytest] (ignoring [pytest])

…tures Merge master into features

pdb: do not raise outcomes.Exit with quit in debug

codecov · 2019-03-29T20:54:18Z

Codecov Report

Merging #5014 into master will increase coverage by 0.36%.
The diff coverage is 97.85%.

@@            Coverage Diff             @@
##           master    #5014      +/-   ##
==========================================
+ Coverage   95.69%   96.06%   +0.36%     
==========================================
  Files         113      114       +1     
  Lines       25178    25749     +571     
  Branches     2498     2548      +50     
==========================================
+ Hits        24095    24735     +640     
+ Misses        765      704      -61     
+ Partials      318      310       -8

Impacted Files	Coverage Δ
src/_pytest/_code/source.py	`91.58% <ø> (ø)`	⬆️
src/_pytest/warnings.py	`88.88% <ø> (ø)`	⬆️
src/_pytest/mark/structures.py	`92.61% <ø> (ø)`	⬆️
src/_pytest/helpconfig.py	`97.29% <ø> (ø)`	⬆️
src/_pytest/outcomes.py	`96.15% <ø> (ø)`	⬆️
testing/test_junitxml.py	`97.8% <ø> (ø)`	⬆️
testing/test_terminal.py	`99.82% <100%> (ø)`	⬆️
testing/deprecated_test.py	`100% <100%> (ø)`	⬆️
src/_pytest/stepwise.py	`96.66% <100%> (+0.51%)`	⬆️
testing/test_modimport.py	`100% <100%> (+18.18%)`	⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2812c08...4621638. Read the comment docs.

Co-Authored-By: nicoddemus <nicoddemus@gmail.com>

blueyed · 2019-03-30T10:42:42Z

Disabled Code Climate's "Pull request status updates" now.
The last time I wanted to do this it reported an actual good issue in a single PR, but this here is not very helpful.

nicoddemus · 2019-03-30T11:43:19Z

OK sounds good.

Other than that, if there are no other issues, please approve. 👍

blueyed · 2019-03-30T11:49:52Z

@nicoddemus
Haven't looked in detail really, would appreciate if somebody else approves it.

nicoddemus · 2019-03-30T11:53:59Z

I have changed the target to features temporarily so it is easier to review. After we get approvals I will change back the target to master and merge. 👍

nicoddemus · 2019-03-30T21:18:55Z

        def test_equals(self, a, b):
    >       assert a == b
    E       assert 1 == 2
-    E         -1


Those changes are actually correct, they were a recent fix by how "verbose" was handled internally by some plugins (-q was being treated as -v in some cases.

Zac-HD

Looks good to me 👍

nicoddemus and others added 30 commits February 19, 2019 08:08

Merge pull request pytest-dev#4808 from nicoddemus/merge-master-into-…

b9561e2

…features Merge master into features

Merge branch 'fix-new-pluggy' into merge-master-into-features

0ca1f6e

Merge pull request pytest-dev#4817 from nicoddemus/merge-master-into-…

63e7f8e

…features Merge master into features (including fix from 4816)

AppVeyor: drop pluggymaster

dc8c270

Require funcsigs>=1.0 on Python 2.7

ede6387

Fix pytest-dev#4815

Merge pull request pytest-dev#4786 from blueyed/av

759d7fd

AppVeyor: use xdist with pypy, drop pluggymaster

-p option now can be used to early-load plugins by entry-point name

a020727

Fixes pytest-dev#4718

Merge pull request pytest-dev#4822 from nicoddemus/funcsigs

c9e6943

Require funcsigs>=1.0 on Python 2.7

Merge pull request pytest-dev#4727 from nicoddemus/early-load-4718

2cf1de3

Change -p so it is possible to early load setuptools plugins

Merge master into features

29112d7

Merge pull request pytest-dev#4833 from blueyed/merge-master

c7bbb2a

Merge master into features

pdb: validate --pdbcls option

a868a9a

_pytest.assertion.rewrite: move _format_explanation import

9cb71af

Merge pull request pytest-dev#4863 from blueyed/remove-import

42561db

Move import of _format_explanation in _pytest.assertion.rewrite

pdb: allow for --pdbclass=mod:attr.class

f7a3e00

Merge pull request pytest-dev#4855 from blueyed/pdbcls-attr

84555c8

--pdbcls: improve validation, and allow for "mod:attr.class"

pytester: unset PYTEST_ADDOPTS

db5cc35

Merge pull request pytest-dev#4868 from blueyed/pytester-unset-PYTEST…

44c9407

…_ADDOPTS pytester: unset PYTEST_ADDOPTS

cacheprovider: _ensure_supporting_files: remove unused branches

2d2f6cd

It is only called with empty/new dirs since 0385c27.

Merge pull request pytest-dev#4872 from blueyed/_ensure_supporting_files

e1f97e4

cacheprovider: _ensure_supporting_files: remove unused branches

Ensure fixtures obtained with getfixturevalue() are finalized in the …

7dceabf

…correct order Fix pytest-dev#1895

Rename fixtures testing file to be consistent with the module name

525639e

Add test and CHANGELOG for pytest-dev#1895

d97473e

Remove code debugging leftovers

6a2d122

Show testpaths option in the header if it has been used for collection

53b8aa0

Fix pytest-dev#4875

Do not show "inifile:" string if there's no configuration file

0deb7b1

Merge pull request pytest-dev#4876 from nicoddemus/show-testpaths-in-…

35c85f0

…header-4875 Show testpaths option in the header if it has been used for collection

Apply suggestions from code review

c334adc

Co-Authored-By: nicoddemus <nicoddemus@gmail.com>

Merge pull request pytest-dev#4860 from nicoddemus/getfixturevalue-cl…

23ea04f

…eanup-1895 getfixturevalue does not correctly declare dependency with the calling fixture

Merge branch 'master' into merge-master-into-features

7668703

Conflicts: appveyor.yml setup.py

blueyed and others added 17 commits March 28, 2019 11:49

Fix/revisit do_continue with regard to conditions

40718ef

add test_pdb_continue_with_recursive_debug

ae067df

Use new suspend/resume in global_and_fixture_disabled

951213e

test_pdb_continue_with_recursive_debug: mock pdb.set_trace

d532099

Factor out pytestPDB._is_capturing

63a01bd

changelog

46d9243

Rename hooks: to/from_serializable

65c8e8a

Merge pull request pytest-dev#4965 from nicoddemus/serialization-hooks

a9fe1e1

Serialization hooks

Merge pull request pytest-dev#4993 from blueyed/stepwise-report

d8ef86a

stepwise: report status via pytest_report_collectionfinish

Merge pull request pytest-dev#4951 from blueyed/fix-pdb-capfix

6b5cddc

pdb: handle capturing with fixtures only

setup.cfg: use existing [tool:pytest] (ignoring [pytest])

bfda2a0

pdb: do not raise outcomes.Exit with quit in debug

4011021

Merge master into features

4e931b2

Merge pull request pytest-dev#5008 from blueyed/setup-cfg-tool-pytest

dee520e

setup.cfg: use existing [tool:pytest] (ignoring [pytest])

Merge pull request pytest-dev#5011 from blueyed/merge-master-into-fea…

e7ade06

…tures Merge master into features

Merge pull request pytest-dev#4968 from blueyed/pdb-do_debug-quit

278b289

pdb: do not raise outcomes.Exit with quit in debug

Preparing release version 4.4.0

8881b20

blueyed reviewed Mar 29, 2019

View reviewed changes

Comment thread CHANGELOG.rst Outdated

Update CHANGELOG.rst

4621638

Co-Authored-By: nicoddemus <nicoddemus@gmail.com>

nicoddemus changed the base branch from master to features March 30, 2019 11:52

nicoddemus commented Mar 30, 2019

View reviewed changes

Zac-HD approved these changes Mar 31, 2019

View reviewed changes

nicoddemus changed the base branch from features to master March 31, 2019 21:14

nicoddemus merged commit 49d690d into pytest-dev:master Mar 31, 2019

nicoddemus deleted the release-4.4.0 branch March 31, 2019 21:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release 4.4.0#5014

Release 4.4.0#5014
nicoddemus merged 156 commits into
pytest-dev:masterfrom
nicoddemus:release-4.4.0

nicoddemus commented Mar 29, 2019

Uh oh!

codecov Bot commented Mar 29, 2019 •

edited

Loading

Uh oh!

Uh oh!

blueyed commented Mar 30, 2019

Uh oh!

nicoddemus commented Mar 30, 2019

Uh oh!

blueyed commented Mar 30, 2019

Uh oh!

nicoddemus commented Mar 30, 2019

Uh oh!

nicoddemus Mar 30, 2019

Uh oh!

Zac-HD left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

nicoddemus commented Mar 29, 2019

Uh oh!

codecov Bot commented Mar 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

blueyed commented Mar 30, 2019

Uh oh!

nicoddemus commented Mar 30, 2019

Uh oh!

blueyed commented Mar 30, 2019

Uh oh!

nicoddemus commented Mar 30, 2019

Uh oh!

nicoddemus Mar 30, 2019

Choose a reason for hiding this comment

Uh oh!

Zac-HD left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Mar 29, 2019 •

edited

Loading