Show testpaths option in the header if it has been used for collection#4876
Merged
nicoddemus merged 2 commits intoMar 2, 2019
Merged
Conversation
blueyed
approved these changes
Mar 2, 2019
blueyed
left a comment
Contributor
There was a problem hiding this comment.
Apart from the inverted logic in the changelog this looks good.
53a3d3e to
b010f07
Compare
Codecov Report
@@ Coverage Diff @@
## features #4876 +/- ##
===========================================
- Coverage 95.76% 92.47% -3.3%
===========================================
Files 113 113
Lines 25744 25239 -505
Branches 2508 2500 -8
===========================================
- Hits 24655 23339 -1316
- Misses 773 1497 +724
- Partials 316 403 +87
Continue to review full report at Codecov.
|
Member
Author
|
Thanks for the quick review. I've pushed another commit also removing What do you think? |
nicoddemus
commented
Mar 2, 2019
| assert color == exp_color | ||
|
|
||
|
|
||
| def test_no_trailing_whitespace_after_inifile_word(testdir): |
Member
Author
There was a problem hiding this comment.
This test is now unnecessary, test_header already covers this.
b010f07 to
0deb7b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4875