[WIP] Debug flaky coverage#4981
Closed
blueyed wants to merge 10 commits into
Closed
Conversation
541d626 to
12e5044
Compare
This reverts commit 12e5044.
This skips all jobs without coverage reporting if "ci-skip-without-coverage" is found in the commit message. This is meant for quicker results on PRs - currently only 5 jobs are run on Travis then, instead of 17.
Merged
feb7889 to
cee7b0f
Compare
ci-skip-without-coverage
70ba3a1 to
503fe39
Compare
Maybe fixes/helps with: https://pytest-dev.visualstudio.com/pytest/_build/results?buildId=549&view=logs&jobId=b93ccf05-0a7e-58c4-578e-33859c8603c3&taskId=d709c56b-0a9a-5e23-1f1b-6f5848010da1&lineStart=63&lineEnd=64&colStart=1&colEnd=1 > Exception ignored in: <_io.FileIO name='…\\\\pytest-0\\\\popen-gw1\\\\test_root_logger_affected0\\\\pytest.log' mode='wb' closefd=True> > ResourceWarning: unclosed file <_io.TextIOWrapper name='…\\\\pytest-0\\\\popen-gw1\\\\test_root_logger_affected0\\\\pytest.log' mode='w' encoding='UTF-8'> Analysis: `test_collect_functools_partial` fails (on purpose via `sys.exit`), because during its collection this shows up on its stderr (via `pytest_make_collect_report`). BUT, the exception and ResourceWarning are referring to the file "pytest.log" from another test (`test_root_logger_affected`, based on the path). In another job the same file from this test is involved, but fails another test then (TestRequestBasic.test_request_addfinalizer). https://pytest-dev.visualstudio.com/pytest/_build/results?buildId=549&view=logs&jobId=eb23edc9-fa61-53da-8734-34b65fb77a8c&taskId=29ab628b-f8ff-5db3-44d6-286eec35d862&lineStart=65&lineEnd=66&colStart=1&colEnd=1 So another test is getting the ResourceWarning in its stderr while collecting modules. This appears to be related to xdist/parallelism. On Travis TestRequestBasic.test_request_attributes_method caught it [1], also via/for "gw0/test_root_logger_affected0/pytest.log". 1: https://travis-ci.org/pytest-dev/pytest/jobs/510010086#L785
2 tasks
Set to None. It should be closed in logging's shutdown [1]. 1: https://github.com/python/cpython/blob/c1419578a18d787393c7ccee149e7c1fff17a99e/Lib/logging/__init__.py#L2107-L2139
Contributor
Author
|
I am a bit surprised that the import logging
# f = open("/tmp/foo", "a")
log_file_handler = logging.FileHandler("temp.log", mode="w", encoding="UTF-8")
root_logger = logging.getLogger()
root_logger.addHandler(log_file_handler)
root_logger.removeHandler(log_file_handler)
root_logger.error("error")
del log_file_handler(run with logging itself handles an internal list (using weakrefs), which normally Anyway, I think this gets triggered by some other test using "-W error" in another thread, while this test is running (xdist)
|
Contributor
Author
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 24, 2019
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 26, 2019
While it should be closed in logging's shutdown [1], the following would
still issue a ResourceWarning:
```
import logging
log_file_handler = logging.FileHandler("temp.log", mode="w", encoding="UTF-8")
root_logger = logging.getLogger()
root_logger.addHandler(log_file_handler)
root_logger.removeHandler(log_file_handler)
root_logger.error("error")
del log_file_handler
```
It looks like the weakref might get lost for some reason.
See pytest-dev@92ffe42b45 / pytest-dev#4981
for more information.
1: https://github.com/python/cpython/blob/c1419578a18d787393c7ccee149e7c1fff17a99e/Lib/logging/__init__.py#L2107-L2139
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 26, 2019
While it should be closed in logging's shutdown [1], the following would
still issue a ResourceWarning:
```
import logging
log_file_handler = logging.FileHandler("temp.log", mode="w", encoding="UTF-8")
root_logger = logging.getLogger()
root_logger.addHandler(log_file_handler)
root_logger.removeHandler(log_file_handler)
root_logger.error("error")
del log_file_handler
```
It looks like the weakref might get lost for some reason.
See pytest-dev@92ffe42b45 / pytest-dev#4981
for more information.
1: https://github.com/python/cpython/blob/c1419578a18d787393c7ccee149e7c1fff17a99e/Lib/logging/__init__.py#L2107-L2139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.