collect: python: fix AssertionError with broken symlinks#4784
Merged
Conversation
blueyed
commented
Feb 13, 2019
Contributor
Author
|
Should we remove the asserts, but only keep them in features? |
Codecov Report
@@ Coverage Diff @@
## master #4784 +/- ##
==========================================
+ Coverage 95.44% 95.66% +0.22%
==========================================
Files 113 113
Lines 25041 25054 +13
Branches 2486 2488 +2
==========================================
+ Hits 23900 23968 +68
+ Misses 806 767 -39
+ Partials 335 319 -16
Continue to review full report at Codecov.
|
b3c069b to
9e9a3a7
Compare
blueyed
commented
Feb 13, 2019
nicoddemus
approved these changes
Feb 14, 2019
nicoddemus
left a comment
Member
There was a problem hiding this comment.
Thanks @blueyed!
About the assert, I should have been more clear: we should avoid plain asserts, because when they fail they don't add any useful information. Asserts where we pass along a failure message should be fine. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4782.