Fix "ValueError: Plugin already registered" exceptions when running in build directories that symlink to actual source.#4738
Merged
Conversation
…n build directories that symlink to actual source.
Codecov Report
@@ Coverage Diff @@
## master #4738 +/- ##
==========================================
+ Coverage 95.67% 95.67% +<.01%
==========================================
Files 113 113
Lines 24968 24980 +12
Branches 2479 2481 +2
==========================================
+ Hits 23887 23899 +12
Misses 762 762
Partials 319 319
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4738 +/- ##
==========================================
+ Coverage 95.67% 95.67% +<.01%
==========================================
Files 113 113
Lines 24968 24980 +12
Branches 2479 2481 +2
==========================================
+ Hits 23887 23899 +12
Misses 762 762
Partials 319 319
Continue to review full report at Codecov.
|
blueyed
approved these changes
Feb 7, 2019
Contributor
Author
|
Thanks!
pt., 8 lut 2019 o 22:57 Bruno Oliveira <notifications@github.com>
napisał(a):
… Merged #4738 <#4738> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4738 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AqnE8STlcgNARGiw0IQjrFLl6CAE80ZLks5vLfLAgaJpZM4ambLl>
.
--
Paweł Stradomski
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some build systems (e.g. bazel) create build directories that have original source files symlinked and not copied or hardlinked.
This confused pytest which tried to refer to a conftest file by realpath in some cases and with symlink path in others, leading to "ValueError: Plugin already registered" exception. This PR fixes that.