Fix #3533: properly escape raw XML object#4167
Merged
crazymerlyn merged 2 commits intoOct 16, 2018
Merged
Conversation
Using string formatting with the raw escaped object lead to string evaluation "<py._xmlgen.raw object>" Format the unescaped string first, then use the XML escape method as a last step.
RonnyPfannschmidt
approved these changes
Oct 16, 2018
Codecov Report
@@ Coverage Diff @@
## master #4167 +/- ##
=========================================
+ Coverage 95.8% 95.8% +<.01%
=========================================
Files 109 109
Lines 23828 23836 +8
Branches 2352 2352
=========================================
+ Hits 22829 22837 +8
Misses 708 708
Partials 291 291
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using string formatting with the raw escaped object lead to string evaluation
resulting in "<py._xmlgen.raw object>" in skipped test Junit report
Format the unescaped string first, then use the XML escape method as a last step.