Skip to content

Revert change of Callinfo.result default value#3562

Merged
RonnyPfannschmidt merged 1 commit into
pytest-dev:masterfrom
nicoddemus:revert-callinfo-result
Jun 11, 2018
Merged

Revert change of Callinfo.result default value#3562
RonnyPfannschmidt merged 1 commit into
pytest-dev:masterfrom
nicoddemus:revert-callinfo-result

Conversation

@nicoddemus

Copy link
Copy Markdown
Member

As discussed in #3560, this should not go to master because this breaks
the API.

Reverts commits:

1a7dcd7
198e993

Follow up of #3560 (review)

As discussed in pytest-dev#3560, this should not go to master because this breaks
the API.

Reverts commits:

1a7dcd7
198e993
@nicoddemus

nicoddemus commented Jun 10, 2018

Copy link
Copy Markdown
Member Author

@alanbato my bad for now realizing this before. Thanks @RonnyPfannschmidt for catching my slip up!

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.07%) to 92.752% when pulling 10b0b81 on nicoddemus:revert-callinfo-result into 80f8a3a on pytest-dev:master.

@nicoddemus

Copy link
Copy Markdown
Member Author

Failure is unrelated: #3564

@RonnyPfannschmidt RonnyPfannschmidt merged commit 61471df into pytest-dev:master Jun 11, 2018
@RonnyPfannschmidt

Copy link
Copy Markdown
Member

sorry i forgot about this one - i couldn't merge on the phone

@nicoddemus nicoddemus deleted the revert-callinfo-result branch June 11, 2018 17:07
nicoddemus added a commit that referenced this pull request Jun 12, 2018
This entry was removed in #3562
blueyed added a commit to blueyed/pytest that referenced this pull request Nov 13, 2018
blueyed added a commit to blueyed/pytest that referenced this pull request Nov 13, 2018
blueyed added a commit to blueyed/pytest that referenced this pull request Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants