fix #13031: use the concrete id NOTSET for the empty parameter list#13073
Merged
RonnyPfannschmidt merged 2 commits intopytest-dev:mainfrom Dec 21, 2024
Conversation
c87c874 to
da7251c
Compare
nicoddemus
reviewed
Dec 18, 2024
changelog/13031.improvement.rst
Outdated
| @@ -0,0 +1,2 @@ | |||
| ``pytest.mark.parametrize([], isfunc=...)`` will no longer call the idfunc with the internal ``NOTSET`` | |||
Member
There was a problem hiding this comment.
isfunc? Is that correct?
Also can you rewrite this from the POV of an user? I mean the description by itself is hard to understand without reading the associated issue first.
nicoddemus
reviewed
Dec 18, 2024
testing/test_mark.py
Outdated
Comment on lines
+1058
to
+1059
| def idfunc(value): | ||
| raise ValueError() |
Member
There was a problem hiding this comment.
Suggested change
| def idfunc(value): | |
| raise ValueError() | |
| def idfunc(value): | |
| raise ValueError() |
nicoddemus
requested changes
Dec 20, 2024
Member
nicoddemus
left a comment
There was a problem hiding this comment.
I think we just need to update the changelog as commented and we're good to go. 👍
Tusenka
approved these changes
Dec 21, 2024
da7251c to
38be67a
Compare
…ter list stand-in this ensures we dont invoke idfunc with the internal NOTSET enum token
38be67a to
4dcbbcb
Compare
nicoddemus
approved these changes
Dec 21, 2024
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Backport to 8.3.x: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 7d585ac on top of patchback/backports/8.3.x/7d585acd1123a6bf6df6ff3279757bb5a69a9417/pr-13073 Backporting merged PR #13073 into main
🤖 @patchback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this ensures we dont invoke idfunc with the internal NOTSET enum token
closes #13031