Revert "Fix teardown error reporting when --maxfail=1 (#11721)"#12022
Merged
bluetech merged 1 commit intopytest-dev:mainfrom Feb 23, 2024
Merged
Revert "Fix teardown error reporting when --maxfail=1 (#11721)"#12022bluetech merged 1 commit intopytest-dev:mainfrom
--maxfail=1 (#11721)"#12022bluetech merged 1 commit intopytest-dev:mainfrom
Conversation
…1721)" Fix pytest-dev#12021. Reopens pytest-dev#11706. This reverts commit 12b9bd5. This change caused a bad regression in pytest-xdist: pytest-dev/pytest-xdist#1024 pytest-xdist necessarily has special handling of `--maxfail` and session fixture teardown get executed multiple times with the change. Since I'm not sure how to adapt pytest-xdist myself, revert for now. I kept the sticky `shouldstop`/`shouldfail` changes as they are good ideas regardless I think.
Member
Author
|
@bbrown1867 FYI |
nicoddemus
approved these changes
Feb 23, 2024
bluetech
pushed a commit
that referenced
this pull request
May 2, 2024
…2279) Closes #11706. Originally fixed in #11721, but then reverted in #12022 due to a regression in pytest-xdist. The regression was fixed on the pytest-xdist side in pytest-dev/pytest-xdist#1026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12021.
Reopens #11706.
This reverts commit 12b9bd5.
This change caused a bad regression in pytest-xdist: pytest-dev/pytest-xdist#1024
pytest-xdist necessarily has special handling of
--maxfailand session fixture teardown get executed multiple times with the change.Since I'm not sure how to adapt pytest-xdist myself, revert for now.
I kept the sticky
shouldstop/shouldfailchanges as they are good ideas regardless I think.