Fix eslint error in pre-commit ci#871
Merged
Merged
Conversation
Contributor
Author
|
For what it's worth, the eslint that this change fixed was; "This assertion is unnecessary since it does not change the type of the expression. @typescript-eslint/no-unnucessary-type-assertion" - const _global = (window || global) as any;
+ const _global = (window || global);ESlint wasn't throwing this issue in a generic Ubutnu 22.04 environment nor in Windows 10, but in a docker image of 22:04 (like what Github actions runners use with |
antocuni
approved these changes
Oct 20, 2022
antocuni
left a comment
Contributor
There was a problem hiding this comment.
brilliant finding!
The ESLint behavior is very weird, but it's good that we finally found it :).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an error that causes eslint to fail in specific environments. Let's see if this allows pre-commit CI to pass for a change...
Edit: it passes! Fixes #834