Skip to content

Fix #2320 - Dispatch an event on code run in PyEditor#2329

Merged
WebReflection merged 3 commits into
pyscript:mainfrom
WebReflection:issue-2320
Apr 16, 2025
Merged

Fix #2320 - Dispatch an event on code run in PyEditor#2329
WebReflection merged 3 commits into
pyscript:mainfrom
WebReflection:issue-2320

Conversation

@WebReflection

Copy link
Copy Markdown
Contributor

Description

This MR would like to fix #2320 by dispatching an event from the script that is related to the PyEditor that is running the code.

Changes

  • find the related script from within the worker and dispatch a py-editor:done once the code has finished running
  • test manually that's the case and everything works as expected

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection requested a review from ntoll April 8, 2025 15:23

@ntoll ntoll left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@WebReflection WebReflection merged commit 7284f7f into pyscript:main Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hooks not working on REPL Run button

2 participants