Allow PyScript to fully run locally#1805
Conversation
| @@ -0,0 +1,4 @@ | |||
| // https://cdn.jsdelivr.net/npm/@webreflection/toml-j0.4/toml.js | |||
There was a problem hiding this comment.
Is there value in noting the specific release of toml-j0.4 here, just in case we (you) ever do an update/release of that project and we want to be able to tell which version is included here? 1.1.3 it lookslike?
There was a problem hiding this comment.
AFAIK nobody is planning to maintain or change that project so I might indeed jut create yet another automated artifact that grabs that from latest version (expected to be always the same) and place it in the src folder before building it.
Or maybe I can just add it as npm dependency and still automate that process ... this actually might be the best way to go:
- the version is embedded in the package.json
- the automation simply reflects that
Good hint!
JeffersGlass
left a comment
There was a problem hiding this comment.
One comment about possibly adding a version number; otherwise Looks Good to Me!
Description
As @fpliger currently spotted, it's harder than it should to run PyScript project offline because we reach the CDN for the optional toml parser.
This MR moves that file locally so that we can use the
distfolder to load on demand that library as opposite of needing the CDN.Changes
pyscript.core/src/folderdistfolderChecklist
docs/changelog.md