Conversation
fritzo
reviewed
Mar 27, 2018
Member
fritzo
left a comment
There was a problem hiding this comment.
Thanks for adding docstrings now that these show up on pyro.ai (after we fix sphinx bugs...)
| non-reparameterizable random variables are present. The Rao-Blackwellization is | ||
| partial in that it only uses conditional independence information that is marked | ||
| by :class:`~pyro.iarange` contexts. For more fine-grained Rao-Blackwellization, | ||
| see :class:`TraceGraph_ELBO`. |
Member
There was a problem hiding this comment.
Thanks for adding nice links! I think you'll need to be explicit about the module:
:class:`~pyro.infer.tracegraph_elbo.TraceGraph_ELBO`
| used to reduce the variance of the gradient estimator. | ||
| and guide as well as baselines for non-reparameterizable random variables. | ||
| Where possible, conditional dependency information as recorded in the | ||
| :class:`Trace` is used to reduce the variance of the gradient estimator. |
Member
There was a problem hiding this comment.
ditto:
:class:`~pyro.poutine.trace.Trace`
| used to reduce variance: | ||
| - the sequential order of samples (z is sampled after y => y does not depend on z) | ||
| - :class:`~pyro.iarange` contexts | ||
| - :class:`~pyro.irange` contexts |
Member
There was a problem hiding this comment.
nit: 'generators' (rather than 'contexts')?
fritzo
approved these changes
Mar 27, 2018
jpchen
approved these changes
Mar 27, 2018
| :class:`~pyro.poutine.trace.Trace` is used to reduce the variance of the gradient estimator. | ||
| In particular three kinds of conditional dependency information are | ||
| used to reduce variance: | ||
| - the sequential order of samples (z is sampled after y => y does not depend on z) |
neerajprad
pushed a commit
to neerajprad/pyro
that referenced
this pull request
May 17, 2018
* first commit * typo * typo#2 * address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this shouldn't be needed anymore. please confirm @neerajprad @fritzo
purpose in life was to test transformeddistribution
closes #816