Conversation
…fy when overwriting existing files. Update _ensure_path_registered to append the correct destination path for third-party extension directories.
Enhance file merging functionality in _merge_publish_into_bin to notify when overwriting existing files. Update _ensure_path_registered to append the correct destination path for third-party extension directories.
Contributor
There was a problem hiding this comment.
PR Summary:
- Fixes a bug in
_ensure_path_registeredwhere the OS-normalized path (norm_dest) was incorrectly persisted to config instead of the original user-provided path (dest_path). - Adds diagnostic logging to
_merge_publish_into_binin the build tooling to surface file overwrites during publish merges.
Review Summary:
Both changes are clean, minimal, and correct. The core fix in script.py addresses a real subtle bug: os.path.normcase lowercases paths on Windows (e.g. C:\Users\MyExt → c:\users\myext), so persisting norm_dest would store a mangled path in user config. Using norm_dest only for comparison (line 64) while storing the original dest_path (line 66) is the right pattern. The _labs.py change is purely informational build-time logging with no side effects. All code in script.py correctly targets IronPython 2.7 (.format() strings, no f-strings), consistent with repository standards.
Suggestions
Contributor
|
📦 New public release are available for 6.3.0.26092+2248 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensions tool