Skip to content

Release touch up 6.3#3256

Merged
jmcouffin merged 2 commits intomasterfrom
develop
Apr 2, 2026
Merged

Release touch up 6.3#3256
jmcouffin merged 2 commits intomasterfrom
develop

Conversation

@jmcouffin
Copy link
Copy Markdown
Contributor

Extensions tool

…fy when overwriting existing files. Update _ensure_path_registered to append the correct destination path for third-party extension directories.
Enhance file merging functionality in _merge_publish_into_bin to notify when overwriting existing files. Update _ensure_path_registered to append the correct destination path for third-party extension directories.
@jmcouffin jmcouffin merged commit bd2f52e into master Apr 2, 2026
1 check failed
Copy link
Copy Markdown
Contributor

@devloai devloai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary:

  • Fixes a bug in _ensure_path_registered where the OS-normalized path (norm_dest) was incorrectly persisted to config instead of the original user-provided path (dest_path).
  • Adds diagnostic logging to _merge_publish_into_bin in the build tooling to surface file overwrites during publish merges.

Review Summary:

Both changes are clean, minimal, and correct. The core fix in script.py addresses a real subtle bug: os.path.normcase lowercases paths on Windows (e.g. C:\Users\MyExtc:\users\myext), so persisting norm_dest would store a mangled path in user config. Using norm_dest only for comparison (line 64) while storing the original dest_path (line 66) is the right pattern. The _labs.py change is purely informational build-time logging with no side effects. All code in script.py correctly targets IronPython 2.7 (.format() strings, no f-strings), consistent with repository standards.

Suggestions

  • Add a unit test for _ensure_path_registered verifying that the original path (not the normalized form) is saved to config. Apply
  • Audit other callers of set_thirdparty_ext_root_dirs to ensure none of them similarly persist normalized paths instead of original user paths. Apply

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

📦 New public release are available for 6.3.0.26092+2248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant