Conversation
…fy when overwriting existing files. Update _ensure_path_registered to append the correct destination path for third-party extension directories.
There was a problem hiding this comment.
PR Summary:
- Adds an overwrite notification in
_merge_publish_into_binwhen a file is being replaced during the build merge step. - Fixes
_ensure_path_registeredto store the originaldest_pathin config instead of thenormcase()-processed (lowercased on Windows)norm_dest.
Review Summary:
Both changes are small, correct, and well-scoped. The script.py fix addresses a real bug: the old code appended norm_dest (the result of os.path.normcase(os.path.normpath(dest_path))) to the config list, which on Windows produces an all-lowercase path — visually wrong and potentially inconsistent with how pyRevit discovers extensions by path comparison. The fix correctly stores the human-readable original path. The _labs.py change is purely informational, adding build-time visibility when files are overwritten during dependency merging. No issues found with IronPython 2.7 compatibility (the extension script uses # -*- coding: utf-8 -*- and no IP2-incompatible constructs), PEP 8 naming, or black formatting.
Suggestions
|
📦 New public release are available for 6.3.0.26092+2248 |
No description provided.