Fix MinifyUI state desync on cross-model view switch by tay0thman · Pull Request #3196 · pyrevitlabs/pyRevit

tay0thman · 2026-03-26T23:59:22Z

Fix MinifyUI state desync on cross-model view switch

Description

Minify Revit UI desynchronizes from actual ribbon visibility when switching between views in different open models. The button stays active (orange), MINIFYUIACTIVE remains True, but contextual tabs like Steel, Precast, and Massing & Site reappear — because Revit's ribbon manager restores them during view activation with no mechanism to re-enforce the hidden state.
This has been reported four times since 2022 (#1570, #1716, #1744, #3106).

Checklist

Before submitting your pull request, ensure the following requirements are met:

Code follows the PEP 8 style guide.
Code has been formatted with Black using the command:
```
pipenv run black {source_file_or_directory}
```
Changes are tested and verified to work as expected.

Related Issues

Closes #3106
Closes #1716
Closes #1570
Related: #1744

Additional Notes

Guard event subscription with a single env var flag (MINIFYUI_SUBSCRIBED) — subscribe once, skip if already subscribed, same pattern as selfinit function detection

Cleared experimental / debugging code

Refactor MinifyUI script to handle icon updates based on active state.

devloai · 2026-03-26T23:59:25Z

Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

Copilot

Pull request overview

Fixes MinifyUI getting out of sync with actual Revit ribbon/tab visibility when switching between views across different open models by re-applying the configured hidden-tab state on view activation.

Changes:

Initializes the MinifyUI smartbutton icon/state on load based on MINIFYUIACTIVE, and (if active) re-applies the hidden tabs immediately.
Adds a guarded ViewActivated event subscription to re-run update_ui() (plus a deferred re-hide) after view switches.
Cleans up minor module metadata (encoding headers) and a docstring typo.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
`extensions/pyRevitTools.extension/pyRevit.tab/Toggles.panel/toggles1.stack/MinifyUI.smartbutton/script.py`	On smartbutton init, syncs icon + (if active) ensures event subscription and re-applies MinifyUI state.
`extensions/pyRevitTools.extension/pyRevit.tab/Toggles.panel/toggles1.stack/MinifyUI.smartbutton/minifyui.py`	Implements guarded `ViewActivated` subscription and deferred UI update to keep hidden tabs enforced across cross-model view switches.

...vitTools.extension/pyRevit.tab/Toggles.panel/toggles1.stack/MinifyUI.smartbutton/minifyui.py

…ggles1.stack/MinifyUI.smartbutton/minifyui.py Adding Debug Exception Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ggles1.stack/MinifyUI.smartbutton/minifyui.py Addubg debug message on exception Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jmcouffin · 2026-03-29T13:38:57Z

Thanks Tay,
Kind of work. switching between 2 projects... you get the tabs to come up again then disappear again.
Not sure this is the right fix.
I'll add reviewer to get second opinion as I cannot deep dive into this one @tay0thman

jmcouffin · 2026-03-29T13:46:22Z

I have had 1 crash and a slowdown at some point while testing, I could not assert it was due to the MinifyUI code though,

sanzoghenzo

Not really the right person, unfortunately I haven't used MinifyUI and I'm not that great at events and dispatchers...
Regardless, I went pedantic as always 😅

...vitTools.extension/pyRevit.tab/Toggles.panel/toggles1.stack/MinifyUI.smartbutton/minifyui.py

tay0thman · 2026-03-29T20:39:39Z

Not sure this is the right fix.
I'll add reviewer to get second opinion as I cannot deep dive into this one @tay0thman

@jmcouffin , before deciding. let me explore updating pyrevit-runtime.dll
The nature of this bug being tied to a monolithic nature of wpf.
If i can fix it on a runtime level, we dont need to have an event handler afterall.

give me a couple of days to look at it, since I understand C# I am bad at writing C#.

tay0thman · 2026-03-30T08:52:54Z

@jmcouffin @sanzoghenzo The fix now uses a C# runtime approach that intercepts Revit's internal tab visibility changes at the data model level. When Revit tries to restore a hidden tab during a view switch, the change is caught and overridden synchronously — before the UI ever renders. This eliminates the flash entirely. No timers, no polling, no deferred callbacks. The compiled runtime DLLs for Revit 2021–2026 are included in the commits below:
318d1a5
14030bf

Tested on Version 2023, 2024 , 2025 and 2026 (I will compile it for 2027 in a week or two)

Revit 2023

Revit 2024

Revit 2025

Revit 2026

Completely changed direction, The PR now propose architectural change at the runtime level not the script level.

Copilot

Pull request overview

Copilot reviewed 3 out of 9 changed files in this pull request and generated 6 comments.

dev/pyRevitLabs.PyRevit.Runtime/EventHandling.cs

...RevitTools.extension/pyRevit.tab/Toggles.panel/toggles1.stack/MinifyUI.smartbutton/script.py

...vitTools.extension/pyRevit.tab/Toggles.panel/toggles1.stack/MinifyUI.smartbutton/minifyui.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

tay0thman · 2026-03-30T09:56:43Z

@jmcouffin I resolved conflict with the latest commits,

github-actions · 2026-03-30T12:42:19Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26089+1231-wip

github-actions · 2026-03-31T05:59:58Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+0549-wip

github-actions · 2026-03-31T15:44:22Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1533-wip

github-actions · 2026-03-31T15:47:11Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1536-wip

github-actions · 2026-03-31T15:51:29Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip

github-actions · 2026-03-31T15:51:32Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip

github-actions · 2026-03-31T16:07:16Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1556-wip

github-actions · 2026-03-31T16:13:41Z

📦 New public release are available for 6.2.0.26090+1754

tay0thman added 2 commits March 26, 2026 16:50

Fix MinifyUI state desync on cross-model view switch (#3106)

8ae2f2f

Refactor MinifyUI script to handle icon updates based on active state.

Add ViewActivated handler with deferred re-hide for tab persistence

b7d7152

tay0thman requested a review from dosymep March 26, 2026 23:59

jmcouffin requested a review from Copilot March 27, 2026 06:54

Copilot started reviewing on behalf of jmcouffin March 27, 2026 06:55 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

tay0thman and others added 2 commits March 27, 2026 01:10

Update extensions/pyRevitTools.extension/pyRevit.tab/Toggles.panel/to…

3b1a286

…ggles1.stack/MinifyUI.smartbutton/minifyui.py Adding Debug Exception Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update extensions/pyRevitTools.extension/pyRevit.tab/Toggles.panel/to…

b89d1a4

…ggles1.stack/MinifyUI.smartbutton/minifyui.py Addubg debug message on exception Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'develop' into tay0thman-patch-6

ad358ff

jmcouffin requested review from MohamedAsli, sanzoghenzo and thumDer March 29, 2026 13:39

jmcouffin added the Enhancement Enhancement request [class->Improved #{number}: {title}] label Mar 29, 2026

sanzoghenzo previously requested changes Mar 29, 2026

View reviewed changes

tay0thman added 2 commits March 30, 2026 01:42

Fix MinifyUI desync with zero-flash C# PropertyChanged intercept (#3106)

318d1a5

Add compiled runtime DLLs for Revit 2021-2026

14030bf

tay0thman requested a review from sanzoghenzo March 30, 2026 08:58

jmcouffin requested a review from Copilot March 30, 2026 09:27

Copilot started reviewing on behalf of jmcouffin March 30, 2026 09:28 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

tay0thman and others added 2 commits March 30, 2026 02:43

Update dev/pyRevitLabs.PyRevit.Runtime/EventHandling.cs

9f32ce4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Resolve merge conflict markers in script.py and minifyui.py

f775703

dosymep approved these changes Mar 30, 2026

View reviewed changes

jmcouffin merged commit c72c0f5 into develop Mar 30, 2026

tay0thman deleted the tay0thman-patch-6 branch March 30, 2026 16:33

Uh oh!

Conversation

tay0thman commented Mar 26, 2026 • edited by jmcouffin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix MinifyUI state desync on cross-model view switch

Description

Checklist

Related Issues

Additional Notes

Uh oh!

devloai bot commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmcouffin commented Mar 29, 2026

Uh oh!

jmcouffin commented Mar 29, 2026

Uh oh!

sanzoghenzo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tay0thman commented Mar 29, 2026

Uh oh!

tay0thman commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tay0thman commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tay0thman commented Mar 26, 2026 •

edited by jmcouffin

Loading

tay0thman commented Mar 30, 2026 •

edited

Loading