Conversation
|
@nodatasheet this should fix the bug you pointed out. Thanks |
There was a problem hiding this comment.
PR Summary:
This PR fixes a bug introduced in commit f81f483 related to function parameter formatting. The main issue was a missing comma after the exitscript parameter in the SelectFromList.show() method, which would cause keyword arguments to be processed incorrectly. The PR also makes several other improvements including removing unnecessary parentheses in a boolean expression, removing an unused import, and adding proper trailing commas to function parameters consistent with Black formatting.
Review Summary:
I've reviewed the changes and identified that the critical fix is the missing comma in the SelectFromList.show() method, which would have caused keyword arguments to be incorrectly processed. The code now properly follows Black formatting requirements as mentioned in the PR description. The changes are well-focused and address the reported issue effectively. Please let me know if you have any feedback on this review that I can incorporate in future reviews.
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25106+0734-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1252-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1322-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1408-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25107+0621-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25116+1412-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25118+1113-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25119+1928-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25133+1246-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0631-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0639-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25140+1615-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25141+1904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25143+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25146+0559-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1012-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1943-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25153+1459-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0858-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0920-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25155+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1125-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1306-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+2030-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+0700-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1347-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1420-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1830-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25171+0757-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25181+1313-wip |
|
📦 New public release are available for 5.2.0.25181+1425 |
fixes commit f81f483 + formatting
Description
bug introduced in commit #f81f483
see f81f483#commitcomment-155417618
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request: