Skip to content

Switch for .net core Desktop connector API#2641

Merged
jmcouffin merged 1 commit intodevelopfrom
fix/2596
Apr 11, 2025
Merged

Switch for .net core Desktop connector API#2641
jmcouffin merged 1 commit intodevelopfrom
fix/2596

Conversation

@jmcouffin
Copy link
Copy Markdown
Contributor

@jmcouffin jmcouffin commented Apr 11, 2025

Switch for .net core Desktop connector API

Description

adc module and keynote manager use the desktop connector API, .net framework 4) works below 2024
Revit 2025-> .net 8 core -> using API from one of the desktop connector subfolder for Civil3D

if HOST_APP.is_newer_than("2024"):  # .net8 core version of the desktop connector API
    ADC_DEFAULT_INSTALL_PATH = (
        r"C:\Program Files\Autodesk\Desktop Connector\FOS\AddInProcess\Civil3DOE"
    )
else:  # .net framework version of the desktop connector API
    ADC_DEFAULT_INSTALL_PATH = r"C:\Program Files\Autodesk\Desktop Connector"

Checklist

Before submitting your pull request, ensure the following requirements are met:

  • Code follows the PEP 8 style guide.
  • Code has been formatted with Black using the command: 
    pipenv run black {source_file_or_directory}
  • Changes are tested and verified to work as expected.

Related Issues

@jmcouffin jmcouffin added the Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] label Apr 11, 2025
@jmcouffin jmcouffin merged commit d06b065 into develop Apr 11, 2025
@jmcouffin jmcouffin deleted the fix/2596 branch April 11, 2025 06:55
devloai[bot]
devloai bot reviewed Apr 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@devloai devloai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary:

This PR adds compatibility for the Autodesk Desktop Connector API with different .NET versions. It addresses an issue with the keynote manager and ADC module by selecting the appropriate API path based on Revit version - using the Civil3D subfolder for Revit 2025+ (.NET 8 Core) and the standard path for older versions (.NET Framework 4).

Review Summary:

The implementation effectively addresses the compatibility issue with a clean, targeted approach. I've identified a couple of areas for improvement related to error handling and managing installation path assumptions. These changes would make the code more robust across different environments and installation configurations.

Feel free to provide feedback on this review for future improvements.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 11, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25101+0700-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 11, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25101+1501-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25104+0813-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25104+1015-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25104+1041-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25104+1127-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25105+0957-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25106+0734-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1252-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1322-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1408-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25107+0621-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 26, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25116+1412-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 28, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25118+1113-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 29, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25119+1928-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 13, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25133+1246-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 16, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0631-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 16, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0639-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 20, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25140+1615-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 21, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25141+1904-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 23, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25143+0904-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 26, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25146+0559-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 29, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1012-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 29, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1943-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25153+1459-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 3, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0858-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 3, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0920-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 4, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25155+0904-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 11, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1125-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 11, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1306-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 11, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25162+2030-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 13, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25164+0700-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 13, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1347-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 13, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1420-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 13, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1830-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 20, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25171+0757-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 30, 2025

📦 New work-in-progress (wip) builds are available for 5.2.0.25181+1313-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 30, 2025

📦 New public release are available for 5.2.0.25181+1425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devloai devloai[bot] devloai[bot] left review comments

Assignees

No one assigned

Labels

Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Keynote Manager and Autodesk Desktop Connector Issues

1 participant

@jmcouffin