Skip to content

Revit 2026 compatibility - first draft#2626

Merged
jmcouffin merged 5 commits intodevelopfrom
revit-2026
Apr 4, 2025
Merged

Revit 2026 compatibility - first draft#2626
jmcouffin merged 5 commits intodevelopfrom
revit-2026

Conversation

@jmcouffin
Copy link
Copy Markdown
Contributor

@jmcouffin jmcouffin commented Apr 2, 2025

Revit 2026 compatibility - first draft

Description

Revit 2026 compatibility - first draft

jmcouffin added 2 commits April 2, 2025 16:27
@jmcouffin
Temp update for 2026
591771c 
\dev\Directory.Build.props needs to be changed once @dosymep accept the PR on Autodesk.Revit.Sdk.Refs repo
@jmcouffin
Update nuget package and build for Revit 2026
0000b86
@jmcouffin jmcouffin added the Runtime Issues related to loading pyRevit runtime [subsystem] label Apr 2, 2025
@jmcouffin jmcouffin marked this pull request as draft April 2, 2025 16:06
devloai[bot]
devloai bot reviewed Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@devloai devloai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary:

This PR adds compatibility for Revit 2026 to the pyRevit code base. It includes:

  • New runtime configuration files supporting Revit 2026
  • Addition of a new pyRevitLabs.PyRevit.Runtime.2026 project
  • Updates to the Visual Studio solution to include the new project
  • UI updates to include Revit 2026 in the available Revit versions list
  • Code reformatting using Black in the affected Python files

Review Summary:

Overall, the implementation looks solid for a first draft of Revit 2026 compatibility. I've identified a couple of minor issues - inconsistent indentation in one file and platform targeting inconsistency in the build configuration. Both issues should be straightforward to fix.

Please feel free to provide feedback on this review which I'll incorporate into future reviews.

@tay0thman
Copy link
Copy Markdown
Contributor

tay0thman commented Apr 2, 2025 •
edited
Loading

Thank you @jmcouffin .
Things seems to work here, at least I managed to get the Color Splasher to work, I'll keep checking and will let you know.

image

@jmcouffin
Copy link
Copy Markdown
Contributor Author

jmcouffin commented Apr 2, 2025

@tay0thman please do go through all tools and report.
There should not be much that pops up. I need to read the API change log to be sure.

@tay0thman
Copy link
Copy Markdown
Contributor

tay0thman commented Apr 2, 2025

I'm on it, will go through all the tools I have and report if there are any issues.

@jmcouffin
Copy link
Copy Markdown
Contributor Author

jmcouffin commented Apr 3, 2025 •
edited
Loading

tay0thman added a commit to tay0thman/pyRevit that referenced this pull request Apr 3, 2025
@tay0thman
Update Color Splasher
9ab10f5 
pyrevitlabs#2626 (comment)

Color Splasher - line 131 DB.ElementId.InvalidElementId (in versions 2024 and earlier) this is ignored and keep default, I get exception thrown for 2025 and 2026, since I don't think we need to change the line pattern, I am proposing to eliminate this line.

Color Splasher - Filter Name separator between cat and param name, added a space in line 364

Color Splasher - Create Legend not working, Fixed the conditional statement,
@tay0thman tay0thman mentioned this pull request Apr 3, 2025
Merged
@tay0thman
Copy link
Copy Markdown
Contributor

tay0thman commented Apr 3, 2025 •
edited
Loading

New PR added for Color Splasher
#2627

@jmcouffin jmcouffin marked this pull request as ready for review April 4, 2025 09:19
@jmcouffin jmcouffin merged commit 87c9bb6 into develop Apr 4, 2025
@jmcouffin jmcouffin added the Tools Issues related to pyRevit commands [subsystem] label Apr 4, 2025
@jmcouffin jmcouffin deleted the revit-2026 branch April 4, 2025 09:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2025

📦 New work-in-progress (wip) builds are available for 5.0.1.25094+0926-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2025

📦 New work-in-progress (wip) builds are available for 5.1.0.25094+0940-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2025

📦 New public release are available for 5.1.0.25094+1133

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2025

📦 New public release are available for 5.1.0.25094+1133

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2025

📦 New public release are available for 5.1.0.25094+1133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devloai devloai[bot] devloai[bot] left review comments

Assignees

No one assigned

Labels

Runtime Issues related to loading pyRevit runtime [subsystem] Tools Issues related to pyRevit commands [subsystem]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmcouffin @tay0thman