Update & Fix Color Splasher #2627
Conversation
pyrevitlabs#2626 (comment) Color Splasher - line 131 DB.ElementId.InvalidElementId (in versions 2024 and earlier) this is ignored and keep default, I get exception thrown for 2025 and 2026, since I don't think we need to change the line pattern, I am proposing to eliminate this line. Color Splasher - Filter Name separator between cat and param name, added a space in line 364 Color Splasher - Create Legend not working, Fixed the conditional statement,
There was a problem hiding this comment.
PR Summary:
This PR addresses three issues with the Color Splasher extension:
- Removes line that sets projection line pattern ID, which causes exceptions in Revit 2025 and 2026
- Fixes a logical error in the legend creation condition (length check)
- Improves filter name format by using a space instead of a forward slash as separator
These changes enhance compatibility with newer Revit versions (2024-2026) and improve the UI readability.
Review Summary:
The PR addresses compatibility issues with newer Revit versions and makes some UI improvements. However, there's a critical syntax error in the updated condition check that needs to be fixed before merging. Your feedback on this review would be valuable for improving future reviews.
Follow-up suggestions:
@devloai fix the syntax error on line 200 by replacing = with ==
extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/ColorSplasher.pushbutton/script.py
Outdated
Show resolved
Hide resolved
extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/ColorSplasher.pushbutton/script.py
Outdated
Show resolved
Hide resolved
|
@tay0thman great, thanks for the elbow oil! |
|
Typo? |
|
Yup, it should be " " |
|
Okay I updated the syntax |
|
@tay0thman thanks for the help |
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25094+0800-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25094+0926-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25094+0940-wip |
|
📦 New public release are available for 5.1.0.25094+1133 |
|
📦 New public release are available for 5.1.0.25094+1133 |
|
📦 New public release are available for 5.1.0.25094+1133 |
Tested on 2024, 2025 and 2026
#2626 (comment)
Color Splasher - line 131 DB.ElementId.InvalidElementId (in versions 2024 and earlier) this is ignored and keep default, I get exception thrown for 2025 and 2026, since I don't think we need to change the line pattern, I am proposing to eliminate this line.
Color Splasher - Filter Name separator between cat and param name, added a space in line 364
Color Splasher - Create Legend not working, Fixed the conditional statement,