fix: CLI, removed exception from ClearAllCaches#2579
Merged
jmcouffin merged 8 commits intopyrevitlabs:developfrom Feb 20, 2025
Merged
fix: CLI, removed exception from ClearAllCaches#2579jmcouffin merged 8 commits intopyrevitlabs:developfrom
jmcouffin merged 8 commits intopyrevitlabs:developfrom
Conversation
Contributor
There was a problem hiding this comment.
I've reviewed the changes that remove the exception from ClearAllCaches. The changes look good and appropriately address the installer failure issue. I have a couple of minor suggestions:
- Consider using the class's logger instance instead of Console.WriteLine for consistency
- Some minor code style improvements around comment placement
Follow-up suggestion: @devloai apply all suggested changes
Co-authored-by: devloai[bot] <168258904+devloai[bot]@users.noreply.github.com>
Co-authored-by: devloai[bot] <168258904+devloai[bot]@users.noreply.github.com>
jmcouffin
previously approved these changes
Feb 13, 2025
Contributor
|
thanks @thumDer |
sanzoghenzo
reviewed
Feb 13, 2025
Contributor
|
Thanks @thumDer and @sanzoghenzo |
Contributor
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25051+1224-wip |
Contributor
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25051+1231-wip |
Contributor
|
📦 New public release are available for 5.0.1.25051+1323 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CLI installer process runs actions with the installed CLI, and in some scenarios (the %APPDATA%\pyRevit directory doesn't exist yet) it throws an exception breaking the installer, that just rolls back.
Related Issues