Skip to content

Patch 1#2452

Closed
andreasdraxl wants to merge 16 commits intopyrevitlabs:developfrom
andreasdraxl:patch-1
Closed

Patch 1#2452
andreasdraxl wants to merge 16 commits intopyrevitlabs:developfrom
andreasdraxl:patch-1

Conversation

@andreasdraxl
Copy link
Copy Markdown
Contributor

@andreasdraxl andreasdraxl commented Nov 1, 2024

OK, merge pull request... let me know if there is stuff still open @jmcouffin

jmcouffin and others added 16 commits September 3, 2024 09:56
This Error has been lingering for a while, I decided to give it a shot.
Causes:
1- Document is not workshared, OR
2- The script is trying to get the .Name and .Category of document objects that doesn't own these attribute objects, this is typical for dependent elements such as sketchplanes, graphicOverrides, roomboundaries.

Solution:
Filter out element that doesn't have a name or a category and sort them under a seperate list called "Unassigned"

Give it a try.
This Model Checker swiftly verifies the extents of the Revit model. 
Placing model extents more than 10 miles from the project's 
internal origin can lead to issues with accuracy, tolerance, 
performance, and viewport display. This check ensures that the 
model remains within a 10-mile radius of the internal origin.
Made the changes below per Jean-Marc's feedback.

1- you may want to present digits results in a tabular form for readability and ease in comparison.

Response: Added output.print_table

2- the project base point cannot be placed at more than 10 miles in more recent version of Revit

Response: Good to know! I removed the report for the location of the project basept.

3- you may want to use the convert unit util to display the distances in the same units as in the UI

Response: I used the unitutils to convert the internal distances to the model distances, however in metric I am having hard time to show the suffix (mm, M, km)....etc

4- you may want to limit the amount of objects output in the output windows using linkify as it may greatly slow the tool

Response: Set the limit of linkify to 10 prints per category, if there are more violating objects, then it will show a message "Manual investigation is required"

5- I tend to prefer print_md over print_html as it is more efficient and improves readability

Response: I switched most of them to use print_md. also I used pyrevit emojis instead of html colors.



please take a look and let me know if this makes sense.
Updated the script for better compliance and fixed issues reported by @jmcouffin and @dosymep
Update radar_check.py - Code Cleanup, expanding tabulated info
This code is based on a true story.

Naming conventions are the foundation of a project. Naming is essential for model checks, filters, and view settings. Until now, I created my checks using Revit export text files with Power-BI. PyRevit enables continuous checking of all categories against their predefined names with just a click.
A template for a loadable .json file.   Just a list of strings.
update extionsion.py added.   file.json template list-template added.
replace static path by select_file(*.json)
add a default path, just for having more confort
@jmcouffin
Copy link
Copy Markdown
Contributor

edited in #2453

@jmcouffin jmcouffin closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants