Skip to content

Update radar_check.py - Rev1#2418

Merged
jmcouffin merged 1 commit intopyrevitlabs:Preflight-Checks_Hackathon_2024from
tay0thman:patch-5
Oct 17, 2024
Merged

Update radar_check.py - Rev1#2418
jmcouffin merged 1 commit intopyrevitlabs:Preflight-Checks_Hackathon_2024from
tay0thman:patch-5

Conversation

@tay0thman
Copy link
Copy Markdown
Contributor

@tay0thman tay0thman commented Oct 16, 2024

Hello @dosymep

Made the changes below per @jmcouffin feedback.

1- you may want to present digits results in a tabular form for readability and ease in comparison.

Response: Added output.print_table

2- the project base point cannot be placed at more than 10 miles in more recent version of Revit

Response: Good to know! I removed the report for the location of the project basept.

3- you may want to use the convert unit util to display the distances in the same units as in the UI

Response: I used the unitutils to convert the internal distances to the model distances, however in metric I am having hard time to show the suffix (mm, M, km)....etc

4- you may want to limit the amount of objects output in the output windows using linkify as it may greatly slow the tool

Response: Set the limit of linkify to 10 prints per category, if there are more violating objects, then it will show a message "Manual investigation is required"

5- I tend to prefer print_md over print_html as it is more efficient and improves readability

Response: I switched most of them to use print_md. also, I used pyrevit emojis instead of html colors.

Please look and let me know if this makes sense.

image

When violations are detected:
image

Made the changes below per Jean-Marc's feedback.

1- you may want to present digits results in a tabular form for readability and ease in comparison.

Response: Added output.print_table

2- the project base point cannot be placed at more than 10 miles in more recent version of Revit

Response: Good to know! I removed the report for the location of the project basept.

3- you may want to use the convert unit util to display the distances in the same units as in the UI

Response: I used the unitutils to convert the internal distances to the model distances, however in metric I am having hard time to show the suffix (mm, M, km)....etc

4- you may want to limit the amount of objects output in the output windows using linkify as it may greatly slow the tool

Response: Set the limit of linkify to 10 prints per category, if there are more violating objects, then it will show a message "Manual investigation is required"

5- I tend to prefer print_md over print_html as it is more efficient and improves readability

Response: I switched most of them to use print_md. also I used pyrevit emojis instead of html colors.



please take a look and let me know if this makes sense.
@jmcouffin jmcouffin merged commit c0c2fcf into pyrevitlabs:Preflight-Checks_Hackathon_2024 Oct 17, 2024
@dosymep
Copy link
Copy Markdown
Member

dosymep commented Oct 17, 2024

@jmcouffin code have some problems the developer forgot to write a method call, and some other little things

image

@jmcouffin
Copy link
Copy Markdown
Contributor

@dosymep I merged it too quickly. 🏃

@jmcouffin jmcouffin mentioned this pull request Oct 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24338+2325-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24340+1616-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24340+1645-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24345+0715-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24351+0714-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24354+1726-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24364+2228-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24364+2256-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24365+2215-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25006+1041-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25009+2113-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25010+1021-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25010+1128-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1201-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1638-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1855-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1857-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25015+1341-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25015+1357-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25024+1520-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25024+1957-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25025+1310-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25030+1056-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25030+1130-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25030+1138-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25031+1700-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25032+1615-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25032+1635-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25032+1841-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25033+1337-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25033+1402-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25034+1241-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25034+1511-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

📦 New public release are available for 5.0.0.24174+2300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants